Search found 7 matches

by erlehmann
Fri Sep 22, 2023 6:18 pm
Forum: Bug reports
Topic: [fixed]TGA files with illegal palette entries cause buffer overflow?
Replies: 9
Views: 2262

Re: TGA files with illegal palette entries cause buffer overflow?

CuteAlien, maybe this patch I just created for tga_encoder helps you to figure out the exact error condition:
https://git.minetest.land/erlehmann/tga ... eca77f062c

You can easily create this yourself using a hex editor by the way.
by erlehmann
Fri Sep 22, 2023 6:15 pm
Forum: Bug reports
Topic: [fixed]TGA files with illegal palette entries cause buffer overflow?
Replies: 9
Views: 2262

Re: TGA files with illegal palette entries cause buffer overflow?

The tga_samples.zip does indeed contain the actual file which makes it corrupt memory (not sure if crash).

Just rename id:000000.bin to crash.tga and you got the file.
by erlehmann
Mon Sep 18, 2023 8:13 pm
Forum: Bug reports
Topic: [fixed]TGA files with illegal palette entries cause buffer overflow?
Replies: 9
Views: 2262

Re: TGA files with illegal palette entries cause buffer overflow?

To quote myself regarding another thing I found: Besides throwing up on illegal colors, it seems to me that the TGA loader code cheats on color depth for palette images. As far as I understand it, it converts all colors to ECF_A1R5G5B5. In the case of the test image, it looks to me like that code re...
by erlehmann
Mon Sep 18, 2023 8:00 pm
Forum: Bug reports
Topic: [fixed]TGA files with illegal palette entries cause buffer overflow?
Replies: 9
Views: 2262

[fixed]TGA files with illegal palette entries cause buffer overflow?

A developer of Minetest, sfan5, has found a problem in the TGA loader code that Minetest inherited from Irrlicht. Since sfan5 does not plan to report it upstream (“currently busy fixing the other bugs AFL found”), I am doing it: The issue happens when a colormapped TGA file has a pixel that refers t...
by erlehmann
Wed Apr 27, 2022 5:34 pm
Forum: Open Discussion and Dev Announcements
Topic: Patches you may want to backport
Replies: 8
Views: 2379

Re: Patches you may want to backport

Correct rounding on x86 with GCC Quote https://github.com/minetest/irrlicht/pull/83 On a x86 system (could affect other platforms that handle floats this way) the x87 fp unit stores floats with 80-bit precision, but when those floats are moved to other registers they suffer from loss of precision a...
by erlehmann
Wed Apr 27, 2022 5:29 pm
Forum: Open Discussion and Dev Announcements
Topic: Patches you may want to backport
Replies: 8
Views: 2379

Re: Patches you may want to backport

Test files for unit tests Test b3d file I used to crash Minetest before sfan5 patched it. https://github.com/minetest/irrlicht/issues/70 Test images files with which I crashed Minetest before sfan5 limited all image dimensions to 23000x23000: 32000x32000 JPEG: https://github.com/minetest/irrlicht/i...
by erlehmann
Wed Apr 27, 2022 5:09 pm
Forum: Open Discussion and Dev Announcements
Topic: Patches you may want to backport
Replies: 8
Views: 2379

Re: Patches you may want to backport

Thanks for the patches. […] Declined: Remove SetThreadAffinityMask calls - still recommended in a 2022 article from Microsoft: https://docs.microsoft.com/en-us/windows/win32/dxtecharts/game-timing-and-multicore-processors Thank you. I kept telling sfan5 that this patch is wrong, he did not believe ...