proposition of API change (addAnimator in particular)

elhim · Post by **elhim** » Mon May 24, 2004 3:24 am

i've struggled a bit with the problem i described earlier here:
http://irrlicht.sourceforge.net/phpBB2/ ... php?t=2050

and to avoid further problems i propose separation of ISceneNode::addAnimator() into addAnimator() and addCollisionAnimator(), which would allow storing the collision animator separately and calling it after all the other animators.
I personaly don't see any problems that could arise from this, but what does the developer/community have to say about this? If people agree i can implement it myself. doesn't take much work and saves a lot of trouble (imho).
comments are welcome, since i might've been completely wrong for the beginning, but yet i want this to be fixed, cause i really need it. also don't want to have to make my own version for my own needs, which would have to be update with every release. thanks

Luke923 · Post by **Luke923** » Sat May 29, 2004 6:21 am

I've been having issues with that, too. I've played around with it a little, but I cannot seem to get it fixed. One of the things that I tried to do is, since the Animators for an IAnimatedSceneNode is nothing more than a deque (double-ended queue), I tried adding to the engine a second addAnimator() function that adds the collision animator to the back of the deque, but still no luck.

I haven't messed with it much lately, but it would be nice if this is something that can get fixed. Maybe I can get this working.

niko · Post by **niko** » Sun May 30, 2004 8:33 am

I thought about an more generic extended addAnimator() method with an additional parameter to make it possible to influcense where the animator will be added. For example at the end or the front. Maybe something like this: addAnimator(ISceneNodeAnimator* anim, bool front=false); Maybe this would be ok?

elhim · Post by **elhim** » Sun May 30, 2004 5:44 pm

oh, good idea. and there could be two versions of the function, one with the parameter, one without. want me to write a patch (for 0.6 obviously)? but there seem to be some other bugs with multiple animators which i haven't looked at much, but i sure will after this gets fixed

niko · Post by **niko** » Mon May 31, 2004 11:29 am

Hm, I think a second default parameter is enough (set to false to ensure backwards compatibility), no need for a second method. I think the other problems I've heard of are because most animators don't update the position of the node after changing it. But I am just guessing.