[fixed]fast_atof bug'n'suggestion

IPv6 · Post by **IPv6** » Thu Dec 27, 2007 4:44 am

Fast_atof incorrectly parsing some floats (which are correctly read by standard atof).

fast_atof("0.43701171875") evaluates to 0.007 instead of 0.437
Error is in "u32 strtol10". It is trying to "atol" value 43701171875 which is bigger than u32 which is causing u32 (DWORD) overflow which is leading to wrong number. i suggest to add limitation to number of characters read after '.' symbol, since they are not that significant at all.

The number itself was exported by script from another software so i think its worth a fix

bitplane · Post by **bitplane** » Thu Dec 27, 2007 10:54 am

I guess the main problem is nobody seems to mind if they write floats or doubles into ascii file formats, even if the spec says floats.
You're right though, it should be limited to 8 chars or less (8 is big enough to hold a 24-bit int)

CuteAlien · Post by **CuteAlien** » Mon Sep 08, 2008 10:06 pm

It also has troubles with floats, see here: http://irrlicht.sourceforge.net/phpBB2/ ... highlight=
(sorry, I did see this thread only afterwards).

rogerborg · Post by **rogerborg** » Sun Oct 26, 2008 1:04 pm

Thanks for the report. This should be fixed in SVN 1647^W 1648.

See bug 1865300 for a test app.