[fixed]Shouldn't addVolumeLightSceneNode return IVolumeLig..

You discovered a bug in the engine, and you are sure that it is not a problem of your code? Just post it in here. Please read the bug posting guidelines first.
Post Reply
MasterGod
Posts: 2061
Joined: Fri May 25, 2007 8:06 pm
Location: Israel
Contact:

[fixed]Shouldn't addVolumeLightSceneNode return IVolumeLig..

Post by MasterGod »

It's pretty weird that addVolumeLightSceneNode() returns an ISceneNode* and not an IVolumeLightSceneNode* interface.
It can save a lot of castings and probably should have been IVolumeLightSceneNode*.

P.S
Does such things should be posted in the bugs forum or here? (edit: here as in Open Discussion forum)
Last edited by MasterGod on Wed Mar 26, 2008 1:02 am, edited 1 time in total.
Image
Dev State: Abandoned (For now..)
Requirements Analysis Doc: ~87%
UML: ~0.5%
vitek
Bug Slayer
Posts: 3919
Joined: Mon Jan 16, 2006 10:52 am
Location: Corvallis, OR

Post by vitek »

Yes, it should return an IVolumeLightSceneNode so you can access the attributes without pointer casting. Yes, you should probably have posted this to the bugs forum, but I'd bet one of the mods will move it for you.

Travis
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Post by hybrid »

Oh, I guess that just went by when I added the interface. The original implementation didn't feature an IVolumeLightSceneNode, so that's just the original return value.
MasterGod
Posts: 2061
Joined: Fri May 25, 2007 8:06 pm
Location: Israel
Contact:

Post by MasterGod »

Does that mean you're going to fix it or would you like me to provide a patch?
Image
Dev State: Abandoned (For now..)
Requirements Analysis Doc: ~87%
UML: ~0.5%
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Post by hybrid »

:lol: No, this time it's not necessary to provide a patch.
Fixed.
Post Reply