Texture refrence counting

[omaremad]

Currently in irrlicht if multiple SMaterials share the same texture they dont grab() a reference to it, so the reference count of the texture stays 1, the makes it impossible to know how many SMaterial's are using a texture and there how mny meshes are using it.

This stops a garbage collector written by the user from cleaning up textures.

Im not sure if this needs to be fixed for everyone, but it reduces the available texture management in irrlicht to just deleting all the textures at once or blindly deleting single textures(no way of knowing if they are in use).

Code: Select all

void setTexture(u32 i, ITexture* tex)
		{
			if (i>=MATERIAL_MAX_TEXTURES)
				return;
			TextureLayer[i].Texture = tex;
		}

how about grabbing in here?

SMaterial.h

[BlindSide]

But the user can still set the texture directly using material.TextureLayer[0].Texture = blah?

What happens if they delete the texture because it was not grabbed when they set it in that fashion and then the user attempts to render that material?

Just kidding, I guess they can just make the Texture member private in SMaterialLayer, just don't forget to do that.

[hybrid]

This is postponed to Irrlicht 2.0 when we clean up all this stuff. Right now it's breaking too many apps.