createFlyCircleAnimator speed value

[jaxl]

What exactly is the units for this "speed" value? I tried setting it to 1 guessing it would be one orbit/sec and was wrong.

createFlyCircleAnimator (
center vector3df(x,y,z),
f32 radius=100.f,
f32 speed=0.001f,
direction vector3df(x,y,z)
);

[JP]

Could be units per second...

[jaxl]

Could be units per second...

Hmm. I took Calc III 3 times, you'd think I'd remember this should work...

Code: Select all

void CSceneNodeAnimatorFlyCircle::init()
{
        Direction.normalize();

        if (Direction.Y != 0)
                VecV = core::vector3df(50,0,0).crossProduct(Direction).normalize();
        else
                VecV = core::vector3df(0,50,0).crossProduct(Direction).normalize();
        VecU = VecV.crossProduct(Direction).normalize();
}


//! animates a scene node
void CSceneNodeAnimatorFlyCircle::animateNode(ISceneNode* node, u32 timeMs)
{
        if ( 0 == node )
                return;

        const f32 t = (timeMs-StartTime) * Speed;

        node->setPosition(Center + Radius * ((VecU*cosf(t)) + (VecV*sinf(t))));
}

[jaxl]

Could be units per second...

Hmm. I took Calc III 3 times, you'd think I'd remember this should work...

Perhaps per ms? I dug out some code..

Code: Select all

void CSceneNodeAnimatorFlyCircle::init()
{
        Direction.normalize();

        if (Direction.Y != 0)
                VecV = core::vector3df(50,0,0).crossProduct(Direction).normalize();
        else
                VecV = core::vector3df(0,50,0).crossProduct(Direction).normalize();
        VecU = VecV.crossProduct(Direction).normalize();
}


//! animates a scene node
void CSceneNodeAnimatorFlyCircle::animateNode(ISceneNode* node, u32 timeMs)
{
        if ( 0 == node )
                return;

        const f32 t = (timeMs-StartTime) * Speed;

        node->setPosition(Center + Radius * ((VecU*cosf(t)) + (VecV*sinf(t))));
}

[rogerborg]

Heh, it appears to be radians per millisecond. I mean, obviously!

We can either comment it as that, or change it to (e.g.) degrees per second in 1.6. Opinions?

[JP]

Probably best to just document it as rps rather than break compatibility by making such a small change?

[jaxl]

Heh, it appears to be radians per millisecond. I mean, obviously!

We can either comment it as that, or change it to (e.g.) degrees per second in 1.6. Opinions?

Ah-Ha, Venus is now going the correct speed around my Sun, thank you..

[rogerborg]

Fair enough. Documented on 1.5 in SVN 2084, and it'll filter down to the trunk later.