[fixed]Chasing a bug in os.cpp

[Jesus.Net]

Hello,

While developing a code based on Irrlicht 1.5, I found something that could be a bug. I'm not sure, I can be wrong, it's your decision.

The allegedly erroneous code is located at the source "os.cpp".
This is the last "#else" it defines "bswap_16(X)."

It shows something like the following:
#define bswap_16 (X) ((((X) & 0xFF) <<8) | (((X) & = 0xFF00)>> 8))

Inside there is a symbol made equal (=) in the second member, after the symbol |, next to the symbol &.

Is this a sign of more? Have you cast this bug? I get the impression that it is, since bswap_32 (X) is not included.

I hope I have helped somewhat.

[vitek]

Code: Select all

#define bswap_16 (X) ((((X) & 0xFF) <<8) | (((X) & = 0xFF00)>> 8))

Sure looks like a bug to me. That said, I wish stuff like this was written as an inline function intead of a macro...

Travis

[hybrid]

Yeah, thanks. Fixed now.

[Jesus.Net]

Code: Select all

#define bswap_16 (X) ((((X) & 0xFF) <<8) | (((X) & = 0xFF00)>> 8))

Sure looks like a bug to me. That said, I wish stuff like this was written as an inline function intead of a macro...

Travis

Not a bad idea, vitek, i never understood why this is here.