[fixed]Phail with removeFileArchive

[B@z]

Hi
Tried out the new irrlicht version, and found a problem.

here is the code:

Code: Select all

	char path[256];
	sprintf(path,"data\\npc\\%i.foo",temp.modelID);
	if (!device->getFileSystem()->addFileArchive(path, true, false, EFAT_ZIP))
		printf("Phail on loading zip archive of npc!\n");

// do something with it

	if (!dev->getFileSystem()->removeFileArchive(dev->getFileSystem()->getAbsolutePath(path)))
	{
		for (int i = 0; i < dev->getFileSystem()->getFileArchiveCount(); i++)
		{
			printf("%s\n", dev->getFileSystem()->getFileArchive(i)->getFileList()->getPath().c_str());
		}
		printf("Didn't found archive: %s\n", dev->getFileSystem()->getAbsolutePath(path).c_str());
	}

the output is:

Code: Select all

c:/Documents and Settings/Honya/Dokumentumok/Visual Studio 2008/Projects/FooServer/FooClient/data/npc/1.foo
Didn!t found archive: c:\Documents and Settings\Honya\Dokumentumok\Visual Studio 2008\Projects\FooServer\FooClient\data\npc\1.foo

focus on the \ / character
looks like the getAbsolutePath use \ and the fileArchive use /

after looking into the code, found another possible bug:

Code: Select all

	for (i = 0; i < FileArchives.size(); ++i)
	{
		if (filename == FileArchives[i]->getFileList()->getPath())
			return true;
	}

but it looks like the getPath() returns absolute path (see the prev. example), but we give the filename relative. so it wont find the same archive (didn't try out, just guessing)

and, it would be good, if it wouldnt return bool, but the index of the loaded archive, and -1 if couldnt load. because on removeFileArchive you can use the index, but from where do you know it!?
yes we can walkaround if we get the count of the fileArchives, coz it uses push_back, but what if found same archive? you wont get the right index.

[B@z]

ok here is a testcase (but isnt hard to test -w- )

just copy it to the Quake3Map when loading the map.

Code: Select all

	int foo = device->getFileSystem()->getFileArchiveCount();
	printf("before loading: %i\n", foo);
	device->getFileSystem()->addZipFileArchive("../../media/map-20kdm2.pk3");
	foo = device->getFileSystem()->getFileArchiveCount();
	printf("after loading the zip: %i\n", foo);
	device->getFileSystem()->addZipFileArchive("../../media/map-20kdm2.pk3");
	foo = device->getFileSystem()->getFileArchiveCount();
	printf("after loading the same zip (should be the same as before): %i\n", foo);
	if (!device->getFileSystem()->removeFileArchive("../../media/map-20kdm2.pk3"))
		printf("failed on remove");
	foo = device->getFileSystem()->getFileArchiveCount();
	printf("after removing: %i\n", foo);

before loading: 0
after loading the zip: 1
after loading the same zip (should be the same as before): 2
failed on remove
after removing: 2

as i thought, the checking for same zip failed, same to removing.

[CuteAlien]

Thanks for bumping this thread and adding more Info. I've seen it first time but forgot about it by now. You can also help keeping such bugs visible by adding them to the bugtracker.

Not sure when I'll find time to investigate this (I'm not too often on Windows these days) but maybe someone else in the team figures it out. But I've put it on my todo and hope I find some time for it before next release.

[B@z]

thank you for answer :3

i hope youll fix it soon

[hybrid]

This seems to be a general file archive problem. The paths are not stored with absolute names, but only relative ones. Which means, that they neither match when loading, nor when removing.