[fixed]Several aabbox3d intersection functions broken in 1.7

You discovered a bug in the engine, and you are sure that it is not a problem of your code? Just post it in here. Please read the bug posting guidelines first.
Post Reply
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

[fixed]Several aabbox3d intersection functions broken in 1.7

Post by CuteAlien »

aabbox3d used the <= and >= operators of the vectors in several function for checking if _all_ elements of a vector are larger than those of another vector. And I changed those operators recently ...

Well, my proposal would be fixing that in aabbox3d, but having just introduced a major bug into our brand new release and not having slept for too many hours I'm open for other proposals.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
Lonesome Ducky
Competition winner
Posts: 1123
Joined: Sun Jun 10, 2007 11:14 pm

Post by Lonesome Ducky »

I guess this means I'll stay at 1.6 :lol: Perhaps you should release a version 1.7.01? I think you may just need a way to get across to the people that this next version is very important
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Post by CuteAlien »

Yeah, pretty bad bug. By now I think the better solution would be to completely remove those operators and replace them with functions instead (which Vitek even had proposed anyway...). Because if we did use it like that - then other people most likely did the same.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Post by hybrid »

Not possible for 1.7.1, though, as this would mean a major change of the APIs. We should just fix aabbox and add a test for this. Strange that I didn't see this in my bbox tests.
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Post by hybrid »

I've added another test (heavily influenced from the pong code) and could reproduce the issue. It is fixed now by expanding the vector comparison to a full element-wise test. I still did not check if other places were also affected by this problem, though.
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Post by CuteAlien »

Thanks for fixing. I just tested it by outcommenting the operators (which I should have done back then...) and at least in Irrlicht there are no other places where it's used except for the sorting (which also could have been implemented without those operators in that case...).
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Post by hybrid »

BTW: This bug also hits the culling and octree implementation quite hard. It causes a drop of 1/3 on the Demo's quake map. So I guess we need to get 1.7.1 out really quick 8)
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Post by CuteAlien »

Yes, I'm all for a quick release.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
Post Reply