Inline animator - recommended or not?

[weeix]

I wonder if we change:

Code: Select all

        scene::IAnimatedMeshSceneNode* anms =
                smgr->addAnimatedMeshSceneNode(smgr->getMesh("../../media/ninja.b3d"));

        if (anms)
        {
                scene::ISceneNodeAnimator* anim =
                        smgr->createFlyStraightAnimator(core::vector3df(100,0,60),
                        core::vector3df(-100,0,60), 3500, true);
                if (anim)
                {
                        anms->addAnimator(anim);
                        anim->drop();
                }

To this form instead:

Code: Select all

        scene::IAnimatedMeshSceneNode* anms =
                smgr->addAnimatedMeshSceneNode(smgr->getMesh("../../media/ninja.b3d"));
        anms->addAnimator(smgr->addAnimatedMeshSceneNode(
                smgr->createFlyStraightAnimator(core::vector3df(100,0,60),
                        core::vector3df(-100,0,60), 3500, true)));

So we don't have to create and then drop the animator anymore. Would this cause any problem later?

[sudi]

Your code shouldn't even compile....

[weeix]

Your code shouldn't even compile....

Sorry, I copied the wrong code

[sudi]

well that code will still not compile but is see what you wanna do.

that code will leak memory since you are not dropping the pointer of the animator.