Addition of IGUITable::getColumnWidth to CGUITable.cpp???

[reifsnyderb]

Hello,

Since there is a setColumnWidth, is there a chance of me talking somebody into adding a getColumnWidth into CGUITable.cpp?

The following code works:


[code]

u32 CGUITable::getColumnWidth(s32 columnIndex) const
{
if(columnIndex >= 0 && columnIndex < (s32)columns.size() )
{
return (u32)columns[columnIndex].width;
}
return 0;
}
[/code]


Regards,

Brian

[reifsnyderb]

Hello,

Since there is a theoretical possibility of a column returning a 0 width, I modified the code so that a -1 is returned if a column doesn't exist. Also, since I re-typed this, as I tested it on another computer, it turns out that I forgot to capitalize "Columns" in my last post.


[code]

s32 CGUITable::getColumnWidth(s32 columnIndex) const
{
if(columnIndex >= 0 && columnIndex < (s32)Columns.size() )
{
return (u32)Columns[columnIndex].width;
}
return -1;
}
[/code]


Regards,

Brian

[CuteAlien]

Ok, I've added that function in trunk.
edit: Just noting in case you wonder:
columnIndex is u32 as in setter (Irrlicht switched at some time to using u32 throughout for indices, a topic discussed elsewhere...)
And returning 0 is fine and we should return u32 as this is an u32 value.

[reifsnyderb]

Great! Thank you.

Regards,

Brian

[ent1ty]

what about getColumnLength ?

[reifsnyderb]

[quote="ent1ty"]what about getColumnLength ?[/quote]


What would getColumnLength() be used for? I figured getColumnWidth() made sense as you set the column width with setColumnWidth()

Regards,

Brian

[ent1ty]

I was, in fact, being sarcastic

[CuteAlien]

I was, in fact, being sarcastic

I was sure of that the first few times, but by now I started wondering ;-)