[Fixed] Patch for CSceneManager.cpp

You discovered a bug in the engine, and you are sure that it is not a problem of your code? Just post it in here. Please read the bug posting guidelines first.
Post Reply
REDDemon
Developer
Posts: 1044
Joined: Tue Aug 31, 2010 8:06 pm
Location: Genova (Italy)

[Fixed] Patch for CSceneManager.cpp

Post by REDDemon »

file : CSceneManager.cpp

method : drawall

lines: from 1325 to 1334

patch: replace lines with provided code.

"driver" and "Driver" are just the same Pointer (and Driver is also checked at the beginning of the method) so i think there is no reason
for keeping it duplicated. Maybe the intended code was the following:

Code: Select all

 
Driver->setMaterial(video::SMaterial());
Driver->setTransform ( video::ETS_PROJECTION, core::IdentityMatrix );
Driver->setTransform ( video::ETS_VIEW, core::IdentityMatrix );
Driver->setTransform ( video::ETS_WORLD, core::IdentityMatrix );
for (i=video::ETS_COUNT-1; i>=video::ETS_TEXTURE_0; --i)
        Driver->setTransform ( (video::E_TRANSFORMATION_STATE)i, core::IdentityMatrix );
 
 
wich is more consistent
Junior Irrlicht Developer.
Real value in social networks is not about "increasing" number of followers, but about getting in touch with Amazing people.
- by Me
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Re: [Patch] Patch for CSceneManager.cpp

Post by hybrid »

Hmm, maybe sometimes moved from somewhere else. I've removed all occurences of getVideoDriver, as this was simply equivalent to direct member access in these cases.
Post Reply