[partially added]IGUIStaticText/IGUIImage patches.

[Nalin]

https://sourceforge.net/tracker/?func=d ... tid=540678
This patch adds some missing methods to IGUIStaticText. The class had some set methods but no matching get method. This patch adds the following methods: getBackgroundColor, isDrawBackgroundEnabled, and isDrawBorderEnabled.
Added to engine in r3939.

https://sourceforge.net/tracker/?func=d ... tid=540678
This patch adds the ability to specify a source rectangle for an IGUIImage.

[CuteAlien]

Thanks, I've applied the IGUIStaticText patch. I removed the const ref for SColor as it makes no difference here (SColor is just a long) and it's without const& in other places where getColor functions are used.

And please - don't shy away creating an own thread for each patch in the future, patches are worth it and it makes any discussions and also marking threads as fixed usually easier.

[Nalin]

Thanks, I've applied the IGUIStaticText patch. I removed the const ref for SColor as it makes no difference here (SColor is just a long) and it's without const& in other places where getColor functions are used.

And please - don't shy away creating an own thread for each patch in the future, patches are worth it and it makes any discussions and also marking threads as fixed usually easier.

Okay. I did it like that to keep it consistent with this method:
virtual video::SColor const & getOverrideColor() const;

Also, do you mean that it would be better to create a thread for each individual patch? I debated with myself on whether I should do that and decided to just create a single thread in the end.

I also found another patch in the tracker that I submitted but never created a thread for:
https://sourceforge.net/tracker/?func=d ... tid=540678

It adds the ability to specify a source rect for an IGUIImage. If you think I should split these patches off into their own topics, I'll do that.

[hybrid]

IMHO it's better to group patches (and discussion about) based on their content. So if you have several patches for GUI it might be ok to keep them in one thread. But even that is usually not necessary (unless for trivial patches, which often don't need a discussion thread either). But putting filesystem and GUI into one thread would make proper discussions pretty complicated.

[Nalin]

Right. I'll split off the IFileSystem patch as the other two are GUI related.

[CuteAlien]

Okay. I did it like that to keep it consistent with this method:
virtual video::SColor const & getOverrideColor() const;

I shouldn't do patches before my first coffee... not only did I not see that - I accidentally removed the const& from getOverrideColor instead messing it up completely *sigh*. Will fix again in a minute ... maybe better remove the const& from getOverrideColor correctly.

[CuteAlien]

Damn, 5 minutes later I realize this means it's no longer identical to IGUIEditBox. And out of curiosity now checked all video::SColor uses in Irrlicht for what is mostly used... I wish I hadn't...