void IMeshBuffer::append(const IMeshBuffer* const other)

[JVr]

This method is missing!

Well it should be changed probably to: bool IMeshBuffer::append(const IMeshBuffer* const other); //in future

However the main problem is that this method does really nothing - someone frgot to uncomment it or to remove it or to fix it whatever..

Code: Select all

 
virtual void append(const IMeshBuffer* const other)
                {
                        if ( this==other )
                                return;
                        if (other->getVertexType () != video::EVT_STANDARD && getVertexType () != other->getVertexType ())
                        {
                                return;
                        }
 
                        append(other->getVertices(),other->getVertexCount(),other->getIndices(),other->getIndexCount());
                }
 

Just submit this or modify it if I'm wrong but it should actually do something and it's comented in 1.7.2 and still commented in current trunk

[serengeor]

this has been talked over a few times in the past, you should probably search the forums to see why it's like that.

[JVr]

I found this but...

http://irrlicht.sourceforge.net/forum/v ... nd#p216293

I have CMeshBuffer class - that has implemented append(const void* const vertices, u32 numVertices, const u16* const indices, u32 numIndices)

(I'm doing a copy from SSkinMeshBuffer)

but "void append(const IMeshBuffer* const other)" seems to be much more correct coz it can do "getVertexType ()" checks...

So anyone to justify why "void append(const IMeshBuffer* const other)" is not implemented in this class?