[fixed] adding a set*ShaderConstant int* interface

hendu · Post by **hendu** » Sun Dec 11, 2011 10:41 am

While integers were only added in OpenGL 3.0, you need to send ints to set GLSL texture samplers currently.

Having to cast that to float* for Irr means the client code can't use strict aliasing, and is a bit ugly.

Requesting an interface be added that takes int* instead of float*. You should be able to trust the user and send it straight to Driver->extGlUniform1iv if the user says they are ints. It's a fairly straight copy-paste job of the existing setPixelShaderConstant function for GLSL.

Any comments?

hendu · Post by **hendu** » Thu Dec 15, 2011 11:14 am

Ping. I'm willing to post patches, but please give me a yea/nay.

I also have no Windows in the house, so I can only do the GL implementation.

Radikalizm · Post by **Radikalizm** » Thu Dec 15, 2011 11:26 am

I second this request
Wouldn't be needed for DX though, integers aren't supported in SM3 shaders, and as far as I know there's no way to use SM4 or SM5 in DX9
Might come in handy for the future though when a decision might be made to include DX10/11 support

hybrid · Post by **hybrid** » Thu Dec 15, 2011 1:07 pm

Yes, that's one where I should have a patch already. Anyway, should be faster if you send in one for this as well.

hendu · Post by **hendu** » Thu Dec 15, 2011 4:44 pm

Posted as

https://sourceforge.net/tracker/index.p ... tid=540678

hendu · Post by **hendu** » Mon Jan 02, 2012 3:37 pm

Ping as the holidays are over.

hendu · Post by **hendu** » Fri Feb 24, 2012 4:51 pm

Ping on this too. It's working quite well here.

hybrid · Post by **hybrid** » Fri Feb 24, 2012 5:18 pm

Yeah, I know. But these API changes need a second thought, as there are also other data types which may need to be automatically converted. So I'd like to have at least a few minutes to go through the current code, the patch, and the hardware driver APIs to get a better impression of the whole scene. And I didn't have enough time so far. But it will be in 1.8 for sure.

hendu · Post by **hendu** » Fri Feb 24, 2012 5:26 pm

So I'd like to have at least a few minutes to go through the current code, the patch, and the hardware driver APIs to get a better impression of the whole scene. And I didn't have enough time so far.

It's been two months since the last post, so I thought I wasn't harassing you too much

Nadro · Post by **Nadro** » Fri Mar 16, 2012 12:52 am

Patch which include methods for all drivers (D3D8, D3D9, OGL) is already on a tracker (compatible with trunk r4105). I also improved code style in Cg files ('p' in a methods parameters was replaced by Irrlicht style).

hendu · Post by **hendu** » Fri Mar 16, 2012 8:19 am

The Cg 'p' changes are unrelated, a separate patch for those would be better IMHO.

Nadro · Post by **Nadro** » Fri Mar 16, 2012 10:47 am

Patch is already applied in a trunk

Irrlicht Engine

[fixed] adding a setShaderConstant int interface

[fixed] adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface

Re: Request for adding a setShaderConstant int interface