[fixed]warning: "/*" within comment [-Wcomment]

[khonkhortisan]

aka. Click here! Easy fix!

I was compiling supertuxkart and got this warning over and over

Code: Select all

[ 77%] Building CXX object CMakeFiles/supertuxkart.dir/src/tracks/track.cpp.o
In file included from /home/kyle/src/stk/supertuxkart/irrlicht/include/IBillboardSceneNode.h:8:0,
                 from /home/kyle/src/stk/supertuxkart/irrlicht/include/IBillboardTextSceneNode.h:8,
                 from /home/kyle/src/stk/supertuxkart/src/tracks/track.cpp:25:
/home/kyle/src/stk/supertuxkart/irrlicht/include/ISceneNode.h:516:3: warning: "/*" within comment [-Wcomment]
In file included from /home/kyle/src/stk/supertuxkart/src/graphics/lod_node.hpp:24:0,
                 from /home/kyle/src/stk/supertuxkart/src/tracks/track.cpp:37:
/home/kyle/src/stk/supertuxkart/irrlicht/include/ISceneNode.h:516:3: warning: "/*" within comment [-Wcomment]

So I ran svn blame

Code: Select all

  2525     hybrid               //! Gets the absolute position of the node in world coordinates.
  2525     hybrid               /** If you want the position of the node relative to its parent,
  2525     hybrid               use getPosition() instead.
  4120  cutealien               /** NOTE: For speed reasons the absolute position is not
  4120  cutealien               automatically recalculated on each change of the relative
  4120  cutealien               position or by a position change of an parent. Instead the
  4120  cutealien               update usually happens once per frame in OnAnimate. You can enforce
  4120  cutealien               an update with updateAbsolutePosition().
  4120  cutealien               \return The current absolute position of the scene node (updated on last call of updateAbsolutePosition). */
  2525     hybrid               virtual core::vector3df getAbsolutePosition() const
  2525     hybrid               {
  2525     hybrid                       return AbsoluteTransformation.getTranslation();
  2525     hybrid               }

r2525 from hybrid and r4120 from cutealien combined cause this warning. Easy enough to fix.
Here's a patch for one way to fix it

Code: Select all

===================================================================
--- include/ISceneNode.h        (revision 4121)
+++ include/ISceneNode.h        (working copy)
@@ -513,7 +513,7 @@
                //! Gets the absolute position of the node in world coordinates.
                /** If you want the position of the node relative to its parent,
                use getPosition() instead.
-               /** NOTE: For speed reasons the absolute position is not 
+               NOTE: For speed reasons the absolute position is not 
                automatically recalculated on each change of the relative 
                position or by a position change of an parent. Instead the 
                update usually happens once per frame in OnAnimate. You can enforce 

You'll have to forgive me for not finding the upload a file button. Again, the file is irrlicht/include/ISceneNode.h line 516.
It was r4121 at the time of this writing and r4122 at the time of submitting.

[CuteAlien]

Ah yeah, my fault. Thanks for reporting, should be fixed now.

[khonkhortisan]

Confirming fixed.