[fixed]FileSystem crash on 64-bit (Windows 8)

[wombat]

I was trying out Irrlicht code (trunk) on Windows 8 64-bit with Visual Studio 2012 and expierenced a crash in a call to

Code: Select all

device->getFileSystem()->addFileArchive()

while trying to add a Folder.

I could identify the source of the crash:
CFileSystem.cpp line 846:

Code: Select all

while( _tfindnext( hFile, &c_file ) == 0 );

hFile is defined as long while _tfindnext expects a initptr_t, which results in a 32 / 64 bit incompability.

The following solves the bug:

Code: Select all

--- source/Irrlicht/CFileSystem.cpp (revision 4309)
+++ source/Irrlicht/CFileSystem.cpp (working copy)
@@ -835,7 +835,7 @@
        r = new CFileList(Path, true, false);
 
        struct _tfinddata_t c_file;
-       long hFile;
+       intptr_t hFile;
 
        if( (hFile = _tfindfirst( _T("*"), &c_file )) != -1L )
        {

best regards
wombat

[CuteAlien]

Thanks for reporting. Not sure right now if we can use intptr_t (depends if this is supported by all compilers we support ...), but definitely needs to be some pointer there and not long.

[hybrid]

Yeah, seems mingw is a bit behind, but found out about that already. Comment from header file:
/* FIXME: Should these all use intptr_t, as per recent MSDN docs? */
But this means for now we need an ifdef there, unless mingw properly resolved intptr_t to long. I don't hope so, though.

[wombat]

yes it might be different for other compilers.

it was just strange because i suspected my own code to cause the crash but could'nt see how such a simple call crashed.