[Not an Issue] CSkinnedMesh incorrect AnimationFrames count

[luthyr]

Because of the optimization that removes duplicate frames, the following section incorrectly sets the wrong amount for AnimationFrames which leads to returning the wrong frame count in GetFrameCount(). Right now I have an animation that stops at frame 40 instead of playing out to frame 91 because of several keys that get optimized out because they are duplicates.

Code: Select all

 
void CSkinnedMesh::checkForAnimation()
{
    ..................
   if (HasAnimation)
    {
        //--- Find the length of the animation ---
        AnimationFrames=0;
        for(i=0;i<AllJoints.size();++i)
        {
            if (AllJoints[i]->UseAnimationFrom)
            {
                if (AllJoints[i]->UseAnimationFrom->PositionKeys.size())
                    if (AllJoints[i]->UseAnimationFrom->PositionKeys.size()+1 > AnimationFrames)
                        AnimationFrames=AllJoints[i]->UseAnimationFrom->PositionKeys.size()+1;
 
                if (AllJoints[i]->UseAnimationFrom->ScaleKeys.size())
                    if (AllJoints[i]->UseAnimationFrom->ScaleKeys.size()+1 > AnimationFrames)
                        AnimationFrames=AllJoints[i]->UseAnimationFrom->ScaleKeys.size()+1;
 
                if (AllJoints[i]->UseAnimationFrom->RotationKeys.size())
                    if (AllJoints[i]->UseAnimationFrom->RotationKeys.size()+1 > AnimationFrames)
                        AnimationFrames=AllJoints[i]->UseAnimationFrom->RotationKeys.size()+1;
            }
        }
    }
}
 

I think it should be something like:

Code: Select all

    if (HasAnimation)
    {
        //--- Find the length of the animation ---
        AnimationFrames=0;
        for(i=0;i<AllJoints.size();++i)
        {
            if (AllJoints[i]->UseAnimationFrom)
            {
                if (AllJoints[i]->UseAnimationFrom->PositionKeys.size())
                    if (AllJoints[i]->UseAnimationFrom->PositionKeys[AllJoints[i]->UseAnimationFrom->PositionKeys.size()-1].frame+1 > AnimationFrames)
                        AnimationFrames=AllJoints[i]->UseAnimationFrom->PositionKeys[AllJoints[i]->UseAnimationFrom->PositionKeys.size()-1].frame+1;
 
                if (AllJoints[i]->UseAnimationFrom->ScaleKeys.size())
               if (AllJoints[i]->UseAnimationFrom->ScaleKeys[AllJoints[i]->UseAnimationFrom->ScaleKeys.size()-1].frame+1 > AnimationFrames)
                  AnimationFrames=AllJoints[i]->UseAnimationFrom->ScaleKeys[AllJoints[i]->UseAnimationFrom->ScaleKeys.size()-1].frame+1;
 
                if (AllJoints[i]->UseAnimationFrom->RotationKeys.size())
               if (AllJoints[i]->UseAnimationFrom->RotationKeys[AllJoints[i]->UseAnimationFrom->RotationKeys.size()-1].frame+1 > AnimationFrames)
                  AnimationFrames=AllJoints[i]->UseAnimationFrom->RotationKeys[AllJoints[i]->UseAnimationFrom->RotationKeys.size()-1].frame+1;
            }
        }
    }

Here is an example model if you want to check it out.

[CuteAlien]

Hm, I've checked all versions from trunk back to even Irrlicht 1.4 and just can't find the wrong code in any of them. Which Irrlicht version are you using?

[luthyr]

You're right, sorry. I don't know how this was changed on our side.

[CuteAlien]

No problem :-)