The latest SVN bugs thread

You discovered a bug in the engine, and you are sure that it is not a problem of your code? Just post it in here. Please read the bug posting guidelines first.
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Re: The latest SVN bugs thread

Post by hybrid »

Maybe also changing the material comparison might help, as it would differentiate those materials then as well
Nadro
Posts: 1648
Joined: Sun Feb 19, 2006 9:08 am
Location: Warsaw, Poland

Re: The latest SVN bugs thread

Post by Nadro »

Yes it will solve this issue, but I think that current solution is good enough (we shouldn't check all SMaterial differences when only SMaterialLayer parameters are different), but as I said require small modification (shift calls depend on SMaterialLayer parameters from setBasicRenderStates to setTextureRenderStates). Another aproach is to put code from setTextureRenderStates to setActiveTexture (and change second parameter from ITexture to SMaterialLayer), but as I now seeing on this solution I think that solution which exist in current OGL trunk with setTextureRenderStates is better. What do You think about unified all drivers in this way?

BTW. Blending in example SpecialFX under OGL is little broken (particles), I'll fix it soon.

UPDATE:
Example no. 08 is fixed in the latest trunk.
Library helping with network requests, tasks management, logger etc in desktop and mobile apps: https://github.com/GrupaPracuj/hermes
Simson
Competition winner
Posts: 95
Joined: Wed Nov 30, 2005 8:53 am
Location: France : midi pyrénées

Re: The latest SVN bugs thread

Post by Simson »

Hi,
I have 2 problems with the SVN REV 4458.
The first is the filter of texture. Sometimes it's correct and sometimes not...
Here screenshot :
Image
Image
My texture appear pixelised.
And the other problem is, when i rotate my camera my bump map effect disappears sometimes.
With the Irrlicht stable release I don't have these problems.
In advance thanks.
Nadro
Posts: 1648
Joined: Sun Feb 19, 2006 9:08 am
Location: Warsaw, Poland

Re: The latest SVN bugs thread

Post by Nadro »

Which driver? Can you post a small test demo where this issue is visible?
Library helping with network requests, tasks management, logger etc in desktop and mobile apps: https://github.com/GrupaPracuj/hermes
Simson
Competition winner
Posts: 95
Joined: Wed Nov 30, 2005 8:53 am
Location: France : midi pyrénées

Re: The latest SVN bugs thread

Post by Simson »

The problem appear in OpenGL with GLSL shader.
To post a demo this is not simple because it's a tool for my game...
Nadro
Posts: 1648
Joined: Sun Feb 19, 2006 9:08 am
Location: Warsaw, Poland

Re: The latest SVN bugs thread

Post by Nadro »

Without a demo it will be very usefull for me if You will be able to check which last revision (mainly commits related to OGL calls optimizations - COpenGLCallBridge) of Irrlicht works properly in your case.
Library helping with network requests, tasks management, logger etc in desktop and mobile apps: https://github.com/GrupaPracuj/hermes
Simson
Competition winner
Posts: 95
Joined: Wed Nov 30, 2005 8:53 am
Location: France : midi pyrénées

Re: The latest SVN bugs thread

Post by Simson »

The problem appear when I Copy a material...the Bilinear Filter is false after the copy.
I'll try to reproduce this bug in a small demo and I'll send as soon as possible.
Nadro
Posts: 1648
Joined: Sun Feb 19, 2006 9:08 am
Location: Warsaw, Poland

Re: The latest SVN bugs thread

Post by Nadro »

It will be nice, with small demo I would fix this issue faster :)
Library helping with network requests, tasks management, logger etc in desktop and mobile apps: https://github.com/GrupaPracuj/hermes
Nadro
Posts: 1648
Joined: Sun Feb 19, 2006 9:08 am
Location: Warsaw, Poland

Re: The latest SVN bugs thread

Post by Nadro »

Mipmapping code related to upload image to GPU is broken (it's visible in example no. 11 on some gfx cards in OGL).
Library helping with network requests, tasks management, logger etc in desktop and mobile apps: https://github.com/GrupaPracuj/hermes
hendu
Posts: 2600
Joined: Sat Dec 18, 2010 12:53 pm

Re: The latest SVN bugs thread

Post by hendu »

The rotation pingpong seemed curious. Why was it reverted?

Texture matrix is not the same as rotation by that patch, see this illustration:
Image
Nadro
Posts: 1648
Joined: Sun Feb 19, 2006 9:08 am
Location: Warsaw, Poland

Re: The latest SVN bugs thread

Post by Nadro »

Yep I know, but we decided that last patch wasn't good (cause some problems in software drivers). In future I think that we'll back to rotation images by an vertices manipulation.
Library helping with network requests, tasks management, logger etc in desktop and mobile apps: https://github.com/GrupaPracuj/hermes
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: The latest SVN bugs thread

Post by CuteAlien »

Sorry, I'm responsible for requesting that revert. Texture roation is not the same, but I was thinking couldn't we apply a transformation matrix for the vertices before calling the function? Sorry, not tested and no code - just intuitively that seems like it would do the same and work with all drivers. And then it wouldn't restrict this to just a rotation around the image center and allow using any transformation instead of only rotation. And wouldn't need an interface change in each driver-code (drivers are the lowest level to get a common interface for drivers - so if it's possible to do something with existing interfaces then the interface shouldn't be made fatter there imho).
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
Simson
Competition winner
Posts: 95
Joined: Wed Nov 30, 2005 8:53 am
Location: France : midi pyrénées

Re: The latest SVN bugs thread

Post by Simson »

Nadro wrote:Mipmapping code related to upload image to GPU is broken (it's visible in example no. 11 on some gfx cards in OGL).
Hi nadro, I would like to know when you think to correct this bug ?
Thanks you.
Nadro
Posts: 1648
Joined: Sun Feb 19, 2006 9:08 am
Location: Warsaw, Poland

Re: The latest SVN bugs thread

Post by Nadro »

In last days I had some more tasks related to my full time job, but at the weekend I shall find time for Irrlicht code :)
Library helping with network requests, tasks management, logger etc in desktop and mobile apps: https://github.com/GrupaPracuj/hermes
greenya
Posts: 1012
Joined: Sun Jan 21, 2007 1:46 pm
Location: Ukraine
Contact:

Re: The latest SVN bugs thread

Post by greenya »

Hello!
This is not about "latest SVN", but about minor bug.

In file CSceneNodeAnimatorDelete.cpp:
Next code

Code: Select all

ISceneNodeAnimator* CSceneNodeAnimatorDelete::createClone(ISceneNode* node, ISceneManager* newManager)
{
    CSceneNodeAnimatorDelete * newAnimator = 
        new CSceneNodeAnimatorDelete(SceneManager, FinishTime);
 
    return newAnimator;
}
Should be replaced with next (which takes into account newManager argument; the same thing done correctly in CSceneNodeAnimatorCollisionResponse.cpp):

Code: Select all

ISceneNodeAnimator* CSceneNodeAnimatorDelete::createClone(ISceneNode* node, ISceneManager* newManager)
{
    if (!newManager) newManager = SceneManager;
 
    CSceneNodeAnimatorDelete * newAnimator = 
        new CSceneNodeAnimatorDelete(newManager, FinishTime);
 
    return newAnimator;
}
Thank you.

P.S.: also very small question: what the "node" argument for? I didn't found any doc or usage of it.
Post Reply