The latest SVN bugs thread

You discovered a bug in the engine, and you are sure that it is not a problem of your code? Just post it in here. Please read the bug posting guidelines first.
Nadro
Posts: 1648
Joined: Sun Feb 19, 2006 9:08 am
Location: Warsaw, Poland

Re: The latest SVN bugs thread

Post by Nadro »

@Foaly
Fixed in trunk. However as CuteAlien said D3D8 will be removed in v1.9.
Library helping with network requests, tasks management, logger etc in desktop and mobile apps: https://github.com/GrupaPracuj/hermes
christianclavet
Posts: 1638
Joined: Mon Apr 30, 2007 3:24 am
Location: Montreal, CANADA
Contact:

Re: The latest SVN bugs thread

Post by christianclavet »

HI, Sorry for the delay. For some reason, my repo used the code for "READ ONLY" and the SVN server was failing connections. I found a HTTP type instead and set it up then was able to update again.

Thanks for the update, I can compile again in MSVC.

For the scale & crash problem. It seem to happen again, tested the GUIEditor example and when I maximized the windows it crashed the same as my application. Checked in debug mode and the code seem to crash in a machine code part after that in CGUIEnvironment.cpp:
> Irrlicht.dll!irr::gui::CGUIEnvironment::postEventFromUser(const irr::SEvent & event={...}) Line 583 + 0x12 bytes C++
Seem something related to events... (By testing my application, It crashed also for about no reason when I was clicking and moving the mouse, it was almost not reproducible, but seem related to the same problem)

To reproduce the problem (Was able to reproduce it 100% with the GUIEditor):

1-Compile the GUIEditor with the TRUNK version
2-Launch it (I selected opengl)
3-Press the maximize Icon

The window will scale, but the content will not, and then the crash happen.

It crashes because of something in CGUIEnvironment.cpp starting from line 583:

Code: Select all

        // Only allow enabled elements to be focused (unless EFF_CAN_FOCUS_DISABLED is set)
            if ( !Hovered->isEnabled() && !(FocusFlags & EFF_CAN_FOCUS_DISABLED))
                focusCandidate = NULL;  // we still remove focus from the active element
As for the exact error when it happen (in french)
Exception non gérée à 0x103b2606 (Irrlicht.dll) dans GUIEditor.exe : 0xC0000005: Violation d'accès lors de la lecture de l'emplacement 0x00000000.
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: The latest SVN bugs thread

Post by CuteAlien »

Thanks again - that was caused by a recent change (focus can have more control now, this bug got added when I programmed that disabled elements no longer get the focus by default unless a specific flag is set to enforce this). Fix is checked in.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
christianclavet
Posts: 1638
Joined: Mon Apr 30, 2007 3:24 am
Location: Montreal, CANADA
Contact:

Re: The latest SVN bugs thread

Post by christianclavet »

Hi, Thanks for this. I updated to REV4813 and used it to replace the 1.8.0 that was in the IRB Project. With some testing. I did not see any errors. So it seem to work fine.

Is there a change on how to set the shader constants? I've got warnings about this, it's compiling and running fine for the moment. I've got report that something "was declared deprecated" in the setPixelShaderConstant and also on the vertex one.

I set them like this:

Code: Select all

services->setPixelShaderConstant(TextureName[i].c_str(), (int*) &i, 1);
And got something like this: (french) :
.\src\fx\postprocess\ShaderMaterial.cpp(161) : warning C4996: 'irr::video::IMaterialRendererServices::setPixelShaderConstant': a été déclaré désapprouvé
1> c:\users\public\projets\irr_rpg_builder - copie\irrlicht-engine\include\IMaterialRendererServices.h(125) : voir la déclaration de 'irr::video::IMaterialRendererServices::setPixelShaderConstant'
One thing that I seeing is that the screen quad for the post process system don't seem to work. I'm using the postFX framework from TBW, and it worked fine with 1.8.0
When I try a post FX now, the screen get black.
When the shaders were compiling I've got also theses errors coming:
Loaded texture: C:/Users/Public/Projets/IRR_RPG_Builder - Copie/media/SKY_DOME.jpg
FBO has one or several incomplete image attachments
FBO error
FBO incomplete
compiling material Full Screen Quad
And the PNG loader now complain about some of my files:
PNG warning: iCCP: known incorrect sRGB profile
Last edited by christianclavet on Tue Apr 29, 2014 11:17 pm, edited 1 time in total.
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: The latest SVN bugs thread

Post by CuteAlien »

Yeah, the old way still works for now, but that interface might be removed some day (not in Irrlicht 1.9). With the new interface you get the id's once by name and then work with id's instead of using the name. The reason is that the constant string-comparisons had a noticable effect on the speed, so this solution is a good deal faster.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
Foaly
Posts: 142
Joined: Tue Apr 15, 2014 8:45 am
Location: Germany

Re: The latest SVN bugs thread

Post by Foaly »

CuteAlien wrote:I'd recommend staying with 1.8 when you want D3D8 support. We're about to remove it and it will likely no longer be in Irrlicht 1.9.
Just wondering what are you still using DX8 for? (just wondering because it's been a while since someone needed that...)
Well, I help greenya writing IrrlichtLime(http://irrlicht.sourceforge.net/forum/v ... =6&t=38512).
We try to wrap everything that's in Irrlicht right now, so when DX8 is removed from Irrlicht, we will remove it, too.
Foaly
Posts: 142
Joined: Tue Apr 15, 2014 8:45 am
Location: Germany

Re: The latest SVN bugs thread

Post by Foaly »

Rev. 4821 doesn't compile. I'm using Visual Studio 2010.
File: GUITreeView.cpp, line 1086 and 1092. I think the _IRR_OVERRIDE_ specifiers aren't allowed to be in a .cpp file.
1>------ Erstellen gestartet: Projekt: Irrlicht, Konfiguration: Debug Win32 ------
1> CGUITreeView.cpp
1>CGUITreeView.cpp(1086): error C2723: 'irr::gui::CGUITreeView::getVerticalScrollBar': Speicherklassenspezifizierer 'override' ungültig für Funktionsdefinition
1>CGUITreeView.cpp(1092): error C2723: 'irr::gui::CGUITreeView::getHorizontalScrollBar': Speicherklassenspezifizierer 'override' ungültig für Funktionsdefinition
========== Erstellen: 0 erfolgreich, Fehler bei 1, 0 aktuell, 0 übersprungen ==========
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: The latest SVN bugs thread

Post by CuteAlien »

@Foaly: Thanks, it's fixed again.

@christianclavet: If you have any examples about the FBO and PNG troubles those would be welcome. I guess for png it would be sufficent if you could send the png - although as we just use a library for loading those it might be it's something in there.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
hendu
Posts: 2600
Joined: Sat Dec 18, 2010 12:53 pm

Re: The latest SVN bugs thread

Post by hendu »

If your PNG files are not srgb, the warning is only cosmetic. If they are, fix them in a proper image editor (load and re-save, making sure colors are correct).
christianclavet
Posts: 1638
Joined: Mon Apr 30, 2007 3:24 am
Location: Montreal, CANADA
Contact:

Re: The latest SVN bugs thread

Post by christianclavet »

@cutealien For getting examples. It's easy, take the XML Postprocessing system from TBW. Worked fine with (1.8.0) until I changed to the TRUNK.

The shaders still seem to compile but it's the screenquad (FBO error seem to come from the screenquad construction) that fail. Also the .PNG are used in the example shaders.
When I use it now, the screen become black.

Here the link to the thread: http://irrlicht.sourceforge.net/forum/v ... =9&t=43743
P.S. I'm using the first version of it, only fixed some of the shaders to compile on more platform.
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Re: The latest SVN bugs thread

Post by hybrid »

Link seems to be down from that thread, so maybe you can re-upload it somewhere?
christianclavet
Posts: 1638
Joined: Mon Apr 30, 2007 3:24 am
Location: Montreal, CANADA
Contact:

Re: The latest SVN bugs thread

Post by christianclavet »

Here is the last version I had of theses.http://www.clavet.org/files/download/ne ... rocess.zip
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: The latest SVN bugs thread

Post by CuteAlien »

Our media/irrlichtlogo3.png is getting "Not recognizing known sRGB profile that has been edited" errors with new libpng. The "length == png_sRGB_checks.length" check failing for i=4 in png_compare_ICC_profile_with_sRGB. Logo still loaded and visible, so probably not too bad. And I guess no one except original png author will have an idea anyway why our png has suddenly gone bad.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
hendu
Posts: 2600
Joined: Sat Dec 18, 2010 12:53 pm

Re: The latest SVN bugs thread

Post by hendu »

The new version is merely more strict, and as mentioned a few posts above, the warning is cosmetic.
CuteAlien
Admin
Posts: 9734
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: The latest SVN bugs thread

Post by CuteAlien »

Ah right was just mentioned above. Sorry, was probably already a little tired. And yeah - solution is to go through all png's, check which are affected and fix those in an image editor.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
Post Reply