Porting old code to 1.8.4 - Billboard Scene misses rotation

[deets]

Hey,

I'm currently porting a 6 year old irrlicht project to the latest version. Most things run, good job on being downwards compatible However, one problem surfaced: IBillboardSceneNode lost the option for setOrientation, wich I rely on.

Before trying my teeth at implementing my own RotatableBillboardSceneNode... do I miss something obvious here?

[CuteAlien]

Hm, I can't remember that it ever had setOrientation (the idea behind billboard is that it does that automatically). Did you maybe add some custom hack to your old Irrlicht version? Otherwise - if you can tell me the exact version I can check in svn if there had been any changes which might have affected this (don't remember any right now, but 6 years is a long time ago...). Btw - if you need rotatable plane you can also just create a mesh with 2 triangles (in blender or so) and use a meshscenenode. Or IGeometryCreator::createPlaneMesh with tile-size one should probably also give you that.

[deets]

Hm, I guess I have to check. I have the old source code somewhere. Maybe I *did* alter the source.

I think I messed up my problem description, though: the call I was missing is setRotation, as the billboard (it's little soap-bubbles in my case) are supposed to rotate around the center. IMHO this degree of freedom is valuable even for a billboard-node. But maybe it really was a customization. I'll be back

[CuteAlien]

Yeah, that feature is also on bugtracker wishlist (or maybe even got a patch, but one I couldn't apply just like that because it had to be reworked). Completely aggree it would be nice to have...

edit: Found that patch: https://sourceforge.net/p/irrlicht/patches/25/
And yeah, reason it didn't get applied is that the patch did too much different stuff *sigh*.
Small patches so much easier to add ...

[deets]

Ah. Ok. I'll try & see if I can make that work then.

A humble suggestion (don't want to start a war on VCS systems): as an old SVN user (back at the time 6 years ago actually), I'm *very* happy with git these days - precisely because of it's rebasing functionalities, where I can take a long, windy piece of refactoring & break it down to small increments, after the fact. Because one doesn't know where the end is when you start

But you probably have discussed this here, so feel free to ignore. I will be back with my suggestion for a simple rotatable billboard scene node.

[CuteAlien]

Yeah, we plan to switch to git this year (after working with it for ~2 years in my job I slowly start to no longer just hate it and my mess-git-up-rate is also somewhat going down... thought personally I still prefer mercurial).

[deets]

OK, I checked, and it seems I actually did patch it myself

If you care, I can try to wrap it up & contribute! I guess a patch is the way to go? Or does SVN sport pull requests these days somehow?

[CuteAlien]

Just patches I think.