Parallax mapping bux (w/ fix)

[jox]

The parallax mapping is really really great! One thing I noticed though, is that the lighting behaves wrong. In one direction (horizontally or vertically) the normal directions are swapped. The following image demonstrates that:



(There is only one light source, I removed the other one from the demo)

I could fix it by replacing the following two lines in CNullDriver.cpp:

Code: Select all

core::vector3df v1(x*hh, nml32(x, y-1, pitch, dim.Height, in)*amplitude, (y-1)*vh);
core::vector3df v2(x*hh, nml32(x, y+1, pitch, dim.Height, in)*amplitude, (y+1)*vh);

with

Code: Select all

core::vector3df v1(x*hh, nml32(x, y+1, pitch, dim.Height, in)*amplitude, (y-1)*vh);
core::vector3df v2(x*hh, nml32(x, y-1, pitch, dim.Height, in)*amplitude, (y+1)*vh);

(the 16 bit version should be similar)

After the change the reflections are correct.

[AlexL]

Thanks for the fix Jox, I was wondering about this and now I don't have to worry about it anymore Thanks again.

[afecelis]

as usual, great work Jox! and thanks for your your sharp eye to catch'em!

[niko]

as usual, great work Jox! and thanks for your your sharp eye to catch'em!

Nothing to add