matrix4::transformBox broken

[RoCKdaFrogg]

I can't really believe nobody noticed this before...

matrix4::transformBox consists of the following code:

Code: Select all

	//! Transforms a axis aligned bounding box
	inline void matrix4::transformBox( core::aabbox3d<f32> &box) const
	{
		transformVect(box.MinEdge);
		transformVect(box.MaxEdge);
		box.repair();
	}

This code is wrong and, for example, sometimes culls nodes when no culling should be done. A simple replacement would be:

Code: Select all

	//! Transforms a axis aligned bounding box
	inline void matrix4::transformBox( core::aabbox3d<f32> &box) const
	{
		vector3df min, max, vec;
		int i;

		min = box.MinEdge;
		max = box.MaxEdge;

		transformVect(box.MinEdge);
		transformVect(box.MaxEdge);
		box.repair();

		for(i = 0; i < 6; i++)
		{
			vec.X = ((i == 0 || i == 1 || i == 2) ? min : max).X;
			vec.Y = ((i == 0 || i == 3 || i == 5) ? min : max).Y;
			vec.Z = ((i == 1 || i == 4 || i == 5) ? min : max).Z;
			transformVect(vec);

			box.addInternalPoint(vec);
		}
	}

Comments appreciated.

[puh]

Wow, you right. It's a long time i try to find what's wrong with occlusion mechanism. Thank you RoCKdaFrogg, it's a seriouse bug, IMHO!

[niko]

Hm, that's right. I think you'll also get some performance boosts out of that, did you try it out?

[puh]

Yes, I have tried. Didn't check performance boost though...

[afecelis]

which file should be modified? I got no search in project-files ability

[bal]

I guess it's "matrix4.h"

[afecelis]

loooooooool!!!

me and my big mouth

edited: forgot to look in the "include" folder; was only looking at the "source" one.

[RoCKdaFrogg]

You won't get a performance boost.

Bounding boxes will now always be bigger (as they should be), as all I added in transformBox is that all 8 corners of the old bounding box are included in the new bounding box. So occlusion will be done in less cases.