Feature Request: getSceneNodeFromName()

[DrAnonymous]

The interface for scene manager has this method -

Code: Select all

ISceneNode* getSceneNodeFromId(s32 id, ISceneNode* start)

I am writing a FLT loader, which has sub groups/nodes. The nodes are named, so I want to be able to load the model and then be able to get a specific sub-node by name from the scene manager.

Could a method called

Code: Select all

getSceneNodeFromName(wchar_t* name, ISceneNode* start)

be added to the ISceneManager class?

Does anyone else think this would be useful for other model formats?

Cheers,
Dr. A>

[etcaptor]

Will be useful. I wrote similar function for my purposes:

Code: Select all

//!Returns the first scene node with the specified Name.
ISceneNode* getSceneNodeFromName(ISceneManager* smgr, ISceneNode* root, stringw  Name)
{
    ISceneNode* resultNode =0;

    if(root ==0)
        root = smgr->getRootSceneNode();

    const core::list<ISceneNode*>& children = root->getChildren();
    core::list<ISceneNode*>::Iterator it = children.begin();

    for (; it != children.end(); ++it)
    {
        ISceneNode* current = *(it);
        if(stringw(current->getName()) == Name)
        {
            resultNode = current;
            return resultNode;
        }

        // if any node has a children apply this function for children by recursion
        if(!current->getChildren().empty())
        {
            getSceneNodeFromName(smgr, current, Name);
        }

    }

 return resultNode;
}

You can use it, only difference is that you must ponit smgr like parameter.

Another function that will be usefull is

Code: Select all

//!Returns scene node with these ID and Name
ISceneNode* getSceneNodeFromNameAndId(ISceneManager* smgr, ISceneNode* root, stringw  Name, s32 id)
{
    ISceneNode* resultNode =0;

    if(root ==0)
        root = smgr->getRootSceneNode();

    const core::list<ISceneNode*>& children = root->getChildren();
    core::list<ISceneNode*>::Iterator it = children.begin();

    for (; it != children.end(); ++it)
    {
        ISceneNode* current = *(it);

        if(stringw(current->getName()) == Name && current->getID() == id)
        {
            resultNode = current;
            return resultNode;
        }

        // if any node has a children apply this function for children by recursion
        if(!current->getChildren().empty())
        {
            getSceneNodeFromNameAndId(smgr, current, Name, id);
        }

    }

 return resultNode;
}

Enjoy.

[DrAnonymous]

I think there is an error in your code. You aren't keeping track of the return from the recursive call.

You have this -

Code: Select all

//!Returns the first scene node with the specified Name.
        // if any node has a children apply this function for children by recursion
        if(!current->getChildren().empty())
        {
            getSceneNodeFromName(smgr, current, Name);
        }

    }

 return resultNode;
}

I believe it should look like this -

Code: Select all

//!Returns the first scene node with the specified Name.
        // if any node has a children apply this function for children by recursion
        if(!current->getChildren().empty())
        {
            resultNode = getSceneNodeFromName(smgr, current, Name);
            if(resultNode != 0)
                  return resultNode;
        }

    }

 return resultNode;
}

Thanks for the info! I hope this is put into the new version.

Cheers,
Dr. A>

[etcaptor]

I think there is an error in your code. You aren't keeping track of the return from the recursive call.

I'm not full agree with this addition, because you will never get executing of this additional line after recursion.
After recussion you have a two return states:
- if name was found /rturns node/
- if name was not found /returns null/[/quote]

[niko]

GetSceneNodebyName(): Already on my list for several releases. Now that some people really need it, time to really add it.