Page 2 of 2

Posted: Wed Dec 24, 2008 3:39 am
by hach-que
If I change Lua to use floats, then it has that problem.

I've managed to change f32 to double, and I've just gone through and replaced f32 with float where ever float is necessary. So far it seems to be working, I'll post if I get weird bugs with it.

Posted: Wed Dec 24, 2008 5:18 am
by Halifax
hach-que wrote:If I change Lua to use floats, then it has that problem.

I've managed to change f32 to double, and I've just gone through and replaced f32 with float where ever float is necessary. So far it seems to be working, I'll post if I get weird bugs with it.
Okay, first off, I'm pretty sure that's exactly what I suggested. Secondly, if this is a commercial product, and your releasing your modified Irrlicht source, then that's a very bad naming scheme. A double should be f64 because it is 64-bits, not f32. So instead you should just go through, and everywhere you kept f32, then change it to f64. Simple as that, then you can change all those floats back to f32! And it will be perfect, simple as that.

But once again, if you are releasing the source code, then you may want to consider making it more friendly for users to modify whether they want that extra precision or not.