[fixed] [patch] - EDS_NORMALS debug

[bitplane]

A couple of minor changes and it's now in the 1.6 branch-

1) I made it check whether to normalize based on the NormalizeNormals parameter of the material, which will also help for debugging purposes.

2) I had to change all your tabs to spaces, which was mildly annoying!

Thanks for the patch

[pc0de]

Thank you.

2) I had to change all your tabs to spaces, which was mildly annoying

Sorry about that, I neglected to run the files through unexpand. It won't happen again.

[bitplane]

Your patches and bug reports are a pleasure to deal with, I think I speak for everyone when I say we appreciate your contributions

[randomMesh]

The normals of the cylinder mesh look totally wrong to me (trunk, rev. 2696):



Small test code

Code: Select all

#include <irrlicht.h>

int main()
{
	irr::IrrlichtDevice* device = irr::createDevice(irr::video::EDT_OPENGL);
	irr::scene::ISceneManager* smgr = device->getSceneManager();
	irr::video::IVideoDriver* driver = device->getVideoDriver();

	smgr->getParameters()->setAttribute(irr::scene::DEBUG_NORMAL_LENGTH, 0.5f);
	smgr->getParameters()->setAttribute(irr::scene::DEBUG_NORMAL_COLOR, irr::video::SColor(255, 255, 0, 0));

	irr::scene::IMesh* const cyl = smgr->getGeometryCreator()->createCylinderMesh(0.5f, 2.0f, 8);
	irr::scene::IMeshSceneNode* node = smgr->addMeshSceneNode(cyl);
	node->setDebugDataVisible(irr::scene::EDS_NORMALS);
	cyl->drop();

	irr::scene::ICameraSceneNode* camera = smgr->addCameraSceneNode();
	camera->setPosition(irr::core::vector3df(0.0f, 0.5f, -4.0f));

	while (device->run())
	{
		driver->beginScene(true, true, irr::video::SColor(255, 255, 255, 255));
		smgr->drawAll();
		driver->endScene();
	}

	device->drop();

	return 0;
}

[pc0de]

This looks like a bug in how createCylinderMesh() is generating the normals, not with how they are being displayed.

[hybrid]

Yes, but that's also what the post wanted to tell us AFAIK. I guess it's a best shot for the number of vertices available, though. So we can either increase the number of vertices, or take slightly wrong lighting. I'm for both solutions, btw., because both could be useful. We need a proper geometry creator with properties for this first. So don' hold your breath for this bug being fixed...

[randomMesh]

Yes, but that's also what the post wanted to tell us AFAIK.

Yes. I realize that this has nothing to do with the original topic.

So don' hold your breath for this bug being fixed...

I won't. He will do.