Multiple texture loading when loading my3d from zip file

Masterhawk · Post by **Masterhawk** » Thu Jul 05, 2007 12:53 am

While playing around with the my3d-loader I found another strange behaviour when loading a my3d file and its textures from a zip archive. All textures get loaded multiple times.

the log without any fixes: (believe me that the list is a few times longer

)

here the log with the "fixed" loader

I made a quick hotfix. I don't know if that really fixes the real problem, but it achieves that the textures get loaded only one time.

I changed

Code: Select all

if (Name.size()>0)
{
            me.Texture2 = Driver->getTexture(me.Texture2FileName.c_str());
            ligCount++;
}

to

Code: Select all

if (Name.size()>0)
{
     ////////////////////////////////////////////////////////////
     //check if texture was loaded before
     for(s32 p=0; p<m;p++)
    {
        if(!strcmp(MaterialEntry[p].Texture2FileName.c_str(), me.Texture2FileName.c_str()))
        {
               me.Texture2 = MaterialEntry[p].Texture2;
               break; 
        }
        else if(p==(m-1))
        {
               me.Texture2 = Driver->getTexture(me.Texture2FileName.c_str());
					         ligCount++;
        } 
     }
     if(m==0)
     {
         me.Texture2 = Driver->getTexture(me.Texture2FileName.c_str());
         ligCount++;  
     }
    ///////////////////////////////////////////////////
                    
}

This has to be changed on the two other similar positions in the code.

I know that this is a really messy code-style (damn, it's about 3 am in germany

), so I hope that a more skilled person hunts this bug down.

hybrid · Post by **hybrid** » Thu Jul 05, 2007 7:47 am

Yeah, code could be optimized. But that's not the point. It rather seems to be a problem with the texture cache, because getTexture should check for existence of the texture already. So I'll check the complete texture loading chain.

Masterhawk · Post by **Masterhawk** » Tue Nov 04, 2008 2:04 pm

hey hybrid, I know this thread is quite old, but in my version of irrlicht (1.1 modified) the problem still occurs. Can you remember that you've fixed it?
I searched the MY3DFileLoader form the trunk, but didn't find a relevant code-change.
Guess I should have a look at the getTexture() method but I don't find the code. Can you tell me where I have to look?

It's quite important cause my new map is currently not loading due to too less memory

(GL_OUT_OF_MEMORY)

rogerborg · Post by **rogerborg** » Tue Nov 04, 2008 2:13 pm

It's in source/Irrlicht/CNullDriver.cpp

CNullDriver::getTexture(const c8* filename)

This method does try to use an already loaded versions of the specified texture, by calling findTexture() to retrieve it from the cache.

This should find already loaded textures from inside a zip archive; in fact, it has an extant problem in that it can't distinguish between the same subpath in different archives (of any sort), so if you have the same/subpath/filename.foo in multiple archives, you'll always get the texture for the first texture that was loaded using this name, regardless of which archive it came from.

In 1.4.2 and below, you'll get the same texture with that filename, even if it was loaded from the filesystem. 1.4.3 / 1.5 will (or should) be able to distinguish between filesystem files in different working directories, and I'll try to extend that to archive files (with some more careful testing).

See the bug report and the followup.

hybrid · Post by **hybrid** » Tue Nov 04, 2008 2:17 pm

No, don't know what was wrong at that time with the texture loader. But you should be able to check the places in the my3d loader and step through the texture loading process with a debugger. A guess would be that the internal texture names are made up with the submesh name and the texture or something like that.