[fixed]Mem Leak: ITexture->lock()

EViruS · Post by **EViruS** » Mon Jul 23, 2007 10:13 am

Memory leak inside:
void *pTexData = pTexture->lock();
pTexture->unlock();

hybrid · Post by **hybrid** » Tue Jul 24, 2007 8:07 am

ITexture->lock() is pure virtual, moreover the code seems to be ok. Could you explain a little more?

EViruS · Post by **EViruS** » Wed Jul 25, 2007 4:45 am

hybrid wrote:ITexture->lock() is pure virtual, moreover the code seems to be ok. Could you explain a little more?

I use Direct3D9 debug runtime and this two lines contain memory leak, which detected by D3D9 debuger.

vitek · Post by **vitek** » Wed Jul 25, 2007 5:46 am

The D3D8/9 Implementations of lock definitely do leak when dealing with a RTT. The surface needs to be released. Have a look here.

Travis

hybrid · Post by **hybrid** » Wed Jul 25, 2007 8:39 am

Is it possible to unlock the surface when the RTTSurface is still being locked, or do I have to keep both locked?

zet.dp.ua · Post by **zet.dp.ua** » Wed Jul 25, 2007 9:21 am

from DX9SDK:

IDirect3DDevice9::GetRenderTargetData
Copies the render-target data from device memory to system memory.

seems what surface can be release after GetRenderTargetData was called

vitek · Post by **vitek** » Wed Jul 25, 2007 10:30 am

Yes, it is safe to Release() as soon as GetRenderTaretData() has returned.

devsh · Post by **devsh** » Wed Dec 01, 2010 6:33 pm

I think the same happens in openGL... how do I get rid of the data?

devsh · Post by **devsh** » Thu Dec 02, 2010 9:29 am

any1?

hybrid · Post by **hybrid** » Thu Dec 02, 2010 12:58 pm

The opengl driver creates a copy internally. This is not released until destruction of the RTT, but it will also not leak. So it's not really a bug, but a missing feature. There's already a ticket for this problem. We simply need more flags for the texture generation and handling.

devsh · Post by **devsh** » Thu Dec 02, 2010 2:38 pm

wait so if I generate 500 cubemaps for SH computation and not delete and re-create the RTT I will leak 1GB?? This is gonna slow me down real BAD

hybrid · Post by **hybrid** » Thu Dec 02, 2010 11:03 pm

No, you don't leak that memory. It's just a copy in CPU memory. It might be the case that if you create RTT and not lock it, you even don't have a mem copy. Check sources to be sure.