[fixed]Bogus comparisons?

[mdeininger]

Hey all, I was going through some other things and noticed a few weird comparisons in some of the inline methods in the irrlicht headers.

In particular, my compiler is complaining about signed/unsigned comparison (also float vs. integer comparisons). In particular:

Code: Select all

SColor.h:
	inline void SColorHSL::fromRGB(const SColor &color)

the code is comparing u32 and f32 in lines 515, 517 and 519.

also:

Code: Select all

SVertexManipulator.h:
		void operator()(video::S3DVertex& vertex) const

line 70, which is this:

Code: Select all

			vertex.Color = (vertex.Color.getAverage()>Threshold)?High:Low;

.... although i'm not sure why the compiler's complaining here, comparing u8 to u32 is legit...

anyway, i'd resolve and patch it myself but i'm not even sure what the first batch is supposed to be doing so i'd better not... any advice here?

merry hacking,
Magnus

EDIT: this was irrlicht 1.7.1, and the compiler that i'm using is borland's. comparing floats and integers with different sizes still seems a bit odd either way...

[CuteAlien]

OK, fixed fixed those. Thanks for reporting.

[mdeininger]

awesome, thanks