ISceneNode cloneMembers + ITriangleSelector

aanderse · Post by **aanderse** » Fri May 06, 2011 10:38 pm

Found a bug in the protected cloneMembers method of the ISceneNode class.

If you look in the code you'll see the line:

setTriangleSelector(toCopyFrom->TriangleSelector);

Problem here is that the triangle selector is not copied/cloned when I clone my scene node. This is no good because a triangle selector is tied to a specific scene node, so if I delete the old scene node but then used the triangle selector from the cloned node I'll likely get a crash, because the triangle selector will try to access the old scene node (which it is tied to).

I'm not sure what the devs want to do here... my guess is adding a copying/cloning implementation to the triangle selector is the way to go.

Comments?

hybrid · Post by **hybrid** » Sat May 07, 2011 9:01 am

IMHO, triangle selectors are, just as animators, external to ISceneNodes. So a cloning of a scene node wouldn't clone any of those. Not sure, though, why it was copied.

aanderse · Post by **aanderse** » Sat May 07, 2011 7:08 pm

Well the animators are cloned and the triangle selectors are not.
Cloning the animators and triangle selectors would be nice... but if you say the animators and triangle selectors are separate from scene nodes then we remove the animator cloning from the scene node class I'll be happy with that answer.

You're happy to have the animator cloning removed then?