[Poll]Texture compression patch (part I)
Posted: Wed Mar 28, 2012 5:15 am
I added a small patch to the tracker. that patch really makes few changes and collect all the changes I need for later implement compressed textures. What is added is (internally) a method for load "hardwaretextures" (textures wich are created before as ITexture and then conversion to IImage is done only if required) and one method for check file extension (because since i'm not using a IImage loader the extension needed to be checked in some way).
My KTX loader need only that patch a no other changes to Irrlicht (especially there is no need for API changes)
The patch was already tested by me with the latest revision (revision 4118).
The following method by the way was not changed (so actually can't create an empty compressed texture):
that method was not changed because I had to do one of the following things (wich was both API changes)
1) equivalent method added to IVideoDriver (addCompressedTexture) (don't know if you developers wanted a new method in IVideoDriver)
OR
2) new enum to color format for specify compressed formats (don't know if you developers want really a new enum that would lead to confunsion for IImage users)
When doing that patch I thinked to make code for DDS/KTX loaders clearly separated so that it is isolated and can be debugged without interference with pre-existing and working implementation (that's mean I avoided any change to current Irrlicht API). When and If the patch is accepted and I have finished new texture loaders I'll add also the second patch wich will add compressed textures implementation definitively.
LINK TO PATCH ON TRACKER:
https://sourceforge.net/tracker/?func=d ... tid=540678
I know that the patch is really little, but I think that's the strongest point. The chance that the patch will not work with bugfixes/new features is really low.
.
My KTX loader need only that patch a no other changes to Irrlicht (especially there is no need for API changes)
The patch was already tested by me with the latest revision (revision 4118).
The following method by the way was not changed (so actually can't create an empty compressed texture):
Code: Select all
virtual ITexture* addTexture(const core::dimension2d<u32>& size,
const io::path& name, ECOLOR_FORMAT format = ECF_A8R8G8B8) = 0;
1) equivalent method added to IVideoDriver (addCompressedTexture) (don't know if you developers wanted a new method in IVideoDriver)
OR
2) new enum to color format for specify compressed formats (don't know if you developers want really a new enum that would lead to confunsion for IImage users)
When doing that patch I thinked to make code for DDS/KTX loaders clearly separated so that it is isolated and can be debugged without interference with pre-existing and working implementation (that's mean I avoided any change to current Irrlicht API). When and If the patch is accepted and I have finished new texture loaders I'll add also the second patch wich will add compressed textures implementation definitively.
LINK TO PATCH ON TRACKER:
https://sourceforge.net/tracker/?func=d ... tid=540678
I know that the patch is really little, but I think that's the strongest point. The chance that the patch will not work with bugfixes/new features is really low.
.
