[solved] missing function IGUIElement::setParent()

[gerdb]

hi,

how do i change the parent of a IGUIElement ?

im using svn4170, my C::B CodeCompletion found a function setParent() but searching IGUIElement.h revealed no such thing.

thx in advance

EDIT: would this be corrent?

Code: Select all

 
    void setParent(IGUIElement* newParent)
    {
        remove();
        
        if (newParent)
        {
            newParent->addChild(this);
            Parent = newParent;
            // maybe recalculate size
        }   
        else
        {
            if (Environment)
            {
                Parent = Environment->getRootGUIElement();
                Parent->addChild(this);
            }
            else
            {
                // ERROR ?
                Parent = 0;
            }           
        }   
    }
 

[REDDemon]

I think that if there is no parent the function should do nothing.
If a user wanna to remove a parent he can do

setParent(0).

as it is, your code will setup a unwanted parent (root), so can happen to users to see a unwanted element drawed.

also setting parent again is redundant since is already done in addChild(), and also calling remove().

Code: Select all

 
virtual void setParent(IGUIElement *newparent)
{
    if(newParent)
    {
        newParent->addChild(this);
    }
}
 

I don't know why no one added "setParent" method. But is not really needed.

instead of doing

Code: Select all

 
element1->setParent(element2);
//you can still do
element2->addChild(element1);
 

probably having only addChild will make the code more consistent and requires 1 less virtual method (in the case some user re-implement addChild, is also forced to re-implement setParent for keep consistency, so I think that could be one of the reasons that method hasn't been added before).

[CuteAlien]

Good questions why it's missing - I hadn't noticed before. As IGUISceneNode has a setParent and addChild it probably makes sense adding it to IGUIElement as well. But I'll just put it on my todo for now as I don't have enough time currently to look into this (maybe it was to prevent ever having 0 as parent or something like that). On first view I'd say calling remove() first looks dangerous, wouldn't that drop the element?

[gerdb]

thank you,

Code: Select all

 
 newParent->addChild(this);
 

does the trick and

probably having only addChild will make the code more consistent and requires 1 less virtual method (in the case some user re-implement addChild, is also forced to re-implement setParent for keep consistency, so I think that could be one of the reasons that method hasn't been added before).

makes complete sense to me.

h.a.n.d.

EDIT:

Code: Select all

 
 
virtual void setParent(IGUIElement *newparent)
{
    if(newParent)
    {
        newParent->addChild(this); // calls this->remove();
    }
    else
    {
        remove(); // Parent = 0; // Element is free and will not be drawn
    }
}
 
 

[REDDemon]

don't call remove. is already called into addchild. and without grabbing first the element will be deleted.

[gerdb]

sorry first post was wrong, but i have to call remove(),

when "newparent = 0", and hope that member this->Parent will be set to 0 through ( removeChild()::*it->Parent=0)

[REDDemon]

well you last snippet has "remove" before the "if" clause and that was not correct. Now that "remove" is the "else" branch it looks ok