Page 1 of 1

Vidmode picks bad fullscreen mode

Posted: Sun May 11, 2014 12:49 pm
by hendu
On some systems, there are a number of "best resolutions", each with different refresh rate and settings.

The current code picks the last mode, which on one user's system was the worst possible one ( http://pastebin.com/iWnDbmnB ) - 30Hz interlaced (eww!).

Patch that ignores interlaced modes, and in addition tries not to modeset at all if possible:

https://github.com/clbr/seirr/commit/bd ... 2918249453
https://github.com/clbr/seirr/commit/0c ... 8d2c84832c

edit: Updated pastebin link.

Re: Vidmode picks bad fullscreen mode

Posted: Mon May 12, 2014 11:41 am
by CuteAlien
Be careful with using other resolutions than the desktop has on X11. I learned recently that chances are pretty high on Linux that this will fail with some DM's no matter if you use vidmode or randr. See this link for more info: http://forums.libsdl.org/viewtopic.php? ... e24f2ec4e3

If I find time (unlikely, but one can dream), I'll try if using render-to-texture with smaller resolutions will give enough speed-boost on Linux so I don't have to ever change resolutions.

Anyway - your patch still makes sense to me on first view.

Re: Vidmode picks bad fullscreen mode

Posted: Mon May 12, 2014 2:57 pm
by hendu
This was hit when using the desktop res.