Page 1 of 1

[fixed]GLES branch - missed a case in COGLESDriver.c

Posted: Fri Apr 22, 2016 2:15 am
by cheqnk
Hello Irrlicht.

I'd like to report a (looks like) bug on GLES branch.
It seems like you are missing a line for D24S8 color format case in COGLESDriver.c line 3155

Code: Select all

             os::Printer::log("ECF_D32 color format is not supported", ELL_ERROR);
        break;
#ifdef GL_OES_packed_depth_stencil
        if (queryOpenGLFeature(COGLES1ExtensionHandler::IRR_OES_packed_depth_stencil))
        {
            internalFormat = GL_DEPTH24_STENCIL8_OES;
            pixelFormat = GL_DEPTH_STENCIL_OES;
            pixelType = GL_UNSIGNED_INT_24_8_OES;
        }
        else
#endif
            os::Printer::log("ECF_D24S8 color format is not supported", ELL_ERROR);
        break;
    case ECF_R8:
 
Where it should be like this.

Code: Select all

             os::Printer::log("ECF_D32 color format is not supported", ELL_ERROR);
        break;
    case ECF_D24S8:
#ifdef GL_OES_packed_depth_stencil
        if (queryOpenGLFeature(COGLES1ExtensionHandler::IRR_OES_packed_depth_stencil))
        {
            internalFormat = GL_DEPTH24_STENCIL8_OES;
            pixelFormat = GL_DEPTH_STENCIL_OES;
            pixelType = GL_UNSIGNED_INT_24_8_OES;
        }
        else
#endif
            os::Printer::log("ECF_D24S8 color format is not supported", ELL_ERROR);
        break;
    case ECF_R8:
 
Have a nice day :)

Re: GLES branch - missed a case in COGLESDriver.c

Posted: Fri Apr 22, 2016 8:34 am
by CuteAlien
Thanks for the report! Fixed now.