Moving CImage interface members up to IImage

Discuss about anything related to the Irrlicht Engine, or read announcements about any significant features or usage changes.
Post Reply
CuteAlien
Admin
Posts: 9741
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Moving CImage interface members up to IImage

Post by CuteAlien »

I just needed the scaleTo function of CImage when I noticed that it's not part of the IImage interface. Similar there are a lot more functions offered by CImage which can currently not be accessed from the outside. As those all look very useful I wonder if there's a reason not to put them in IImage?
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
rogerborg
Admin
Posts: 3590
Joined: Mon Oct 09, 2006 9:36 am
Location: Scotland - gonnae no slag aff mah Engleesh
Contact:

Post by rogerborg »

Uh, the what function? I can't see CImage::scaleTo() in SVN 1344.

I do see some CImage methods that aren't in IImage, and I can't see any good reason why they can't be exposes there. CImage seems to be the only implementor of IImage.
Please upload candidate patches to the tracker.
Need help now? IRC to #irrlicht on irc.freenode.net
How To Ask Questions The Smart Way
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Post by hybrid »

Yes, there had been some patches and requests on the tracker already, should be done for 1.5. However, the interface might also require some general clean up and a merge with the ITexture interface in order to remove some inconsistencies...
BTW: the method is called copyToScaling()
CuteAlien
Admin
Posts: 9741
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Post by CuteAlien »

Oops - didn't want to write scaleTo. I actually meant the copyTo which copies without scaling :-)
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
Post Reply