[fixed]Pixelshader debug problem..

NewerCookie · Post by **NewerCookie** » Sat Jan 10, 2009 1:42 pm

hi everyone, im first this forum

i tried debugging pixelshader in irrlicht 1.5
irrlicht make "irr_d3d9_dbg_hlsl_~.vsh"

...ok, then... where "irr_d3d9_dbg_hlsl_~.psh"??

finally, i found CD3D9HLSLMaterialRenderer.cpp
it don't make "irr_d3d9_dbg_hlsl_~.psh"

this topic discussed previously? i cant find..

NewerCookie · Post by **NewerCookie** » Wed Jan 21, 2009 6:09 am

i have been wait reply.. nothing

anyway, i fixed it. code below..
patch file here : http://www.mediafire.com/?jzo0gmtuogr

Code: Select all

	#ifdef _IRR_D3D_NO_SHADER_DEBUGGING

	HRESULT h = stubD3DXCompileShader(
		pixelShaderProgram,
		strlen(pixelShaderProgram), 
		0, // macros
		0, // no includes
		shaderEntryPointName,
		shaderTargetName,
		0, // no flags (D3DXSHADER_DEBUG)
		&buffer,
		&errors,
		&PSConstantsTable);

	#else

	// compile shader and emitt some debug informations to
	// make it possible to debug the shader in visual studio

	static int irr_dbg_hlsl_file_nr = 0; 
	++irr_dbg_hlsl_file_nr;
	char tmp[32];
	sprintf(tmp, "irr_d3d9_dbg_hlsl_%d.psh", irr_dbg_hlsl_file_nr);

	FILE* f = fopen(tmp, "wb");
	fwrite(pixelShaderProgram, strlen(pixelShaderProgram), 1, f);
	fflush(f);
	fclose(f);

	HRESULT h = stubD3DXCompileShaderFromFile(
		tmp,
		0, // macros
		0, // no includes
		shaderEntryPointName,
		shaderTargetName,
		D3DXSHADER_DEBUG | D3DXSHADER_SKIPOPTIMIZATION,
		&buffer,
		&errors,
		&PSConstantsTable);

	#endif

hybrid · Post by **hybrid** » Wed Jan 21, 2009 8:26 am

Ok, I get your point. Question is if it's really necessary to create a file first. Can't we just put the debug flags to the first call, just conditionally?

NewerCookie · Post by **NewerCookie** » Wed Jan 21, 2009 1:47 pm

You mean.. "irr_d3d9_dbg_hlsl_~.psh" file making support by debug flag?
I think always make "irr_d3d9_dbg_hlsl_~.psh" is better..
I'm misunderstanding?

hybrid · Post by **hybrid** » Wed Jan 21, 2009 4:18 pm

I don't see any reason why I'd want to create a file first, and then load and compile it again (with Debug flags on). We could do the debugging also with the IReadFile handle used in the true-branch of the ifdef.
And no, always writing the file is no option.

NewerCookie · Post by **NewerCookie** » Thu Jan 22, 2009 5:15 am

I don't understand you or not.. I don't know

Sorry, I have poor english

Simply, my question is
Why don't irrlicht make "Psh" files in "CD3D9HLSLMaterialRenderer.cpp"
Even if i undef "_IRR_D3D_NO_SHADER_DEBUGGING", irrlicht make just "Vsh" file only

hybrid · Post by **hybrid** » Thu Jan 22, 2009 8:39 am

What are those files good for? Do you need the file, or do you need the debug mode enabled for your shader?

NewerCookie · Post by **NewerCookie** » Fri Jan 23, 2009 8:27 am

Yes, I need the file that "irr_d3d9_dbg_hlsl_~.psh"
I can't debug pixelshader without it
So, I fixed engine code

hybrid · Post by **hybrid** » Fri Jan 23, 2009 9:27 pm

fixed in SVN trunk.