[fixed] [patch] - EDS_NORMALS debug

[pc0de]

Patch: 2838269 - Fix for EDS_NORMALS debug

This patch fixes EDS_NORMALS debug visual for CMeshSceneNode & CAnimatedMeshSceneNode.cpp. It replaces the arrow mesh with a 3D line. It also allows setting the debug normal Length & Color through ISceneNode.

Before:


After: (with default normal color)

[bitplane]

I agree, the arrow mesh is a bad way to do normals, it's too slow and covers most of the screen. Let's see what the other devs think before adding it though

[FuzzYspo0N]

i think its awesome btw. much better than those arrows and the options make it a win.

[hybrid]

I like the simplicity of the line call, but the two additional parameters with members and getters/setters seem to be overkill.

[Nox]

Hmm why? I think that these parameters may be interesting for someone. Especially the linelength.

[twilight17]

Looks much better!

[bitplane]

Hmm why? I think that these parameters may be interesting for someone. Especially the linelength.

New functions are considered bad by default, feature creep is our enemy!

[pc0de]

...but the two additional parameters with members and getters/setters seem to be overkill.

The ability to set/get the color isn't all that important to me personally, but I think having the ability to set the length has some merit. The default length of 1 looks a bit small in "09.MeshViewer.exe":

[bitplane]

Maybe it could be a scene parameter instead?

[BlindSide]

Normals aren't all necessarily normalized so the length would be determined by the normal itself. You can have a "length mutiplier" though to adjust the length if you desire.

[Steel Style]

I think that a good thing I use to have this kind of problem while I was working on loader the arrow was too short.

[pc0de]

Maybe it could be a scene parameter instead?

I like this better - saves having to update each node to a length other than the default.

Normals aren't all necessarily normalized so the length would be determined by the normal itself

Yes, forgot about that:

Code: Select all

driver->draw3DLine(v->Pos, v->Pos + (v->Normal * DebugNormalLength), DebugNormalColor);

// replaced with:

normalizedNormal = v->Normal;
normalizedNormal.normalize();

driver->draw3DLine(v->Pos, v->Pos + (normalizedNormal * DebugNormalLength), DebugNormalColor);

[pc0de]

Updated patch (debugnormals2.patch):

1. Extract debug normal length & color from SceneManager Parameters.
2. Use normalized normal.

[FuzzYspo0N]

Good work pc0de

[pc0de]

Thanks FuzzYspo0N and everyone else for the input.