[PATCH] loadScene and saveScene with parent (loadSubScene)

[wts]

Hi,
I've modified loadScene adding a ISceneNode* as parameter.
It's useful to create ripetitive scenes.

This is the patch:
https://sourceforge.net/tracker/?func=d ... tid=540679

[CuteAlien]

Thanks, I think it's probably a good idea.

[Acki]

yes, nice idea...
but there is one thing that's not so good:

Code: Select all

-  virtual bool loadScene(const io::path& filename, ISceneUserDataSerializer* userDataSerializer=0) = 0;
+  virtual bool loadScene(const io::path& filename, ISceneNode* parent=0, ISceneUserDataSerializer* userDataSerializer=0) = 0;

this changes can break older codes !!!
you should set "ISceneNode* parent=0" as last parameter, so older codes will work without changing the code...
or make a new (overwritten) function...

and another nice addition would be to make the saveScene function similar...

[wts]

this changes can break older codes !!!
you should set "ISceneNode* parent=0" as last parameter, so older codes will work without changing the code...

I thought it, but watching the doc i notice that ISceneNode*parent is ever the first default parameter, and I think it's more likely that ISceneUserDataSerializer* is passed as NULL

or make a new (overwritten) function...

Something like this?

Code: Select all

bool CSceneManager::loadScene(const io::path& filename, ISceneUserDataSerializer* userDataSerializer)
{
return loadScene(filename, 0, userDataSerializer);
}

and another nice addition would be to make the saveScene function similar...

I'm working on it

[wts]

Hi,
I've modified previous patch:
- readSceneNode now doesn't create a new emptynode
- added functions for backward compatibility
- added saveScene with 'ISceneNode* parent' parameter

Note:
saveScene doesn't use parent's attributes (position, orientation scale, ecc) but root's

Feedback is highly appreciated!

Bye^2