[fixed]WAL loader misses include guards

You discovered a bug in the engine, and you are sure that it is not a problem of your code? Just post it in here. Please read the bug posting guidelines first.
Post Reply
hendu
Posts: 2600
Joined: Sat Dec 18, 2010 12:53 pm

[fixed]WAL loader misses include guards

Post by hendu »

The WAL image loader misses the include guards (if it's not defined in IrrCompileConfig).

This causes longer compile times, and slightly bigger lib even when it's disabled in IrrCompileConfig (I measured 10kb).

Some other loaders may miss them too, but WAL with its big arrays caught my attention. Please add those guards for all loaders that miss them.
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Re: WAL loader misses include guards

Post by hybrid »

Yeah, should be fixed in 1.7 branch now. Image writers still to be checked, though. Thanks for reporting.
Edit: Writers are all ok, so fixed.
hendu
Posts: 2600
Joined: Sat Dec 18, 2010 12:53 pm

Re: [fixed]WAL loader misses include guards

Post by hendu »

I updated my 1.7 svn checkout, but it's not there. Not pushed to SF / SF having issues?
hybrid
Admin
Posts: 14143
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany
Contact:

Re: [fixed]WAL loader misses include guards

Post by hybrid »

Oh, sorry. Seems that I chose the wrong directory, so it's only in trunk. Sorry for the confusion.
Post Reply