[DONE]Would need more rows in the ComboBox gui...

[christianclavet]

Hi, Looking at the code, I just saw that the combobox is limited to max 5 rows of text.

as this is defined: MaxSelectionRows(5) in

Code: Select all

CGUIComboBox::CGUIComboBox(IGUIEnvironment* environment, IGUIElement* parent,
    s32 id, core::rect<s32> rectangle)
    : IGUIComboBox(environment, parent, id, rectangle),
    ListButton(0), SelectedText(0), ListBox(0), LastFocus(0),
    Selected(-1), HAlign(EGUIA_UPPERLEFT), VAlign(EGUIA_CENTER), MaxSelectionRows(5), HasFocus(false)
{ 

I find it OK as a default value, but would be nice if we could get methods to change the values along the way.
Methods could be like this:

Code: Select all

CGUIComboBox::setMaxSelectionRows (s32 MaxRows)
{
    MaxSelectionRows=MaxRows;
}
 
s32 MaxRows CGUIComboBox::getMaxSelectionRows()
{
    Return MaxSelectionRows;
}

[CuteAlien]

It's already changed like that in trunk ;-)

[christianclavet]

ha! Cool! Thanks CuteAlien! I'm still using 1.7.3 for my project.
Once Irrlicht 1.8 will be out, that will give me another reason to switch the lib inside my project! (changing the cursor pointer is another great thing you added that I will use for the stretching windows I have implemented)