CAnimatedMeshSceneNode.cpp clone memory issues [FIXED]

[luthyr]

It seems that CAnimatedMeshSceneNode::clone() may have some issues with reference counts and grabbing. At least, when I have been cloning meshes with animation callbacks, they get prematurely deleted and cause crashes.

Should

Code: Select all

newNode->LoopCallBack = LoopCallBack;
newNode->PassCount = PassCount;
newNode->Shadow = Shadow;
newNode->Shadow->grab();

be

Code: Select all

newNode->LoopCallBack = LoopCallBack;
if (newNode->LoopCallBack)
   newNode->LoopCallBack->grab();
newNode->PassCount = PassCount;
newNode->Shadow = Shadow;
if (newNode->Shadow)
   newNode->Shadow->grab();

?

EDIT: Sorry, typo.

[CuteAlien]

Thanks for your report - your changes seem to be correct. Well... second check should only be "if (newNode->Shadow)", but I guess that was a typo.

Not sure yet if I'll be able to be back to Irrlicht programming before next release, so I hope someone else in the team can add it (to 1.8 branch I guess).

[Nadro]

As I remember it's already fixed in v1.8.1 branch, if not I'll apply this patch today.

[CuteAlien]

I thought the same at first :-) But seems we fixed some other clone problems - but not this one yet.

[Nadro]

OK, so as I said before I'll fix it today in v1.8.1 branch

[Nadro]

Fixed.