[fixed] Do unit tests for fast_atof() check something ?

[cerf]

Hello,

I was just looking the unit tests for fast_atof() in trunk/tests/fast_atof.cpp and wondering if the function testCalculation_atof() does really check something.

Here is the source code in irrlicht SVN repo :
http://sourceforge.net/p/irrlicht/code/ ... of.cpp#l84

Take a look at those lines (93 & 94) :

Code: Select all

 
        const f32 diffNew = fabs(newFastValue - atofValue) ;
        const f32 diffOld = fabs(newFastValue - atofValue) ;
        bool accurate = diffNew <= diffOld || equalsByUlp(diffNew, diffOld, 1); 
 

diffNew and diffOld have the same values, so the "accurate" test shall always return true.

Do I miss something ?

[CuteAlien]

Thanks, should certainly use oldFastValue instead. I'll fix it later on.

edit: Fixed now in svn trunk.

[cerf]

Glad to help.

Another question in my mind is why accuracy is not checked against libc's atof() too ?
Currently accuracy is only checked against old implementation of fast_atof().

[CuteAlien]

Good question, don't know.