[fixed]Cameras showing up in collisions

You discovered a bug in the engine, and you are sure that it is not a problem of your code? Just post it in here. Please read the bug posting guidelines first.
robmar
Posts: 1125
Joined: Sun Aug 14, 2011 11:30 pm

Re: [fixed]Cameras showing up in collisions

Post by robmar »

That would work, but a bit of a hack! ;)
CuteAlien
Admin
Posts: 9694
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: [fixed]Cameras showing up in collisions

Post by CuteAlien »

Yes, that would have allowed to hack around it. And certainly one could work with ID's. But I couldn't figure out a reason that it behaved like it did, so I suppose changing it was better.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
robmar
Posts: 1125
Joined: Sun Aug 14, 2011 11:30 pm

Re: [fixed]Cameras showing up in collisions

Post by robmar »

So IYO the correct solution is to add the function isVisible to ICameraSceneNode so that it simply returns false?

I had changed the ISceneNode root class function to check if it was a camera node, but then that impacts all classes derived from it, which is a slight extra overhead on all nodes.
CuteAlien
Admin
Posts: 9694
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: [fixed]Cameras showing up in collisions

Post by CuteAlien »

I won't stop you from doing that - might work for your case. But my solution was to change the boundingbox and the collision code. You can update to new svn if you want to use that.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
robmar
Posts: 1125
Joined: Sun Aug 14, 2011 11:30 pm

Re: [fixed]Cameras showing up in collisions

Post by robmar »

Okay, that sounds good. I always have a problem finding these patches in the SVN, its like a back hole for me! Any chance of a link to the new source?
CuteAlien
Admin
Posts: 9694
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: [fixed]Cameras showing up in collisions

Post by CuteAlien »

This patch is here: https://sourceforge.net/p/irrlicht/code/5094/
It also contains a bunch of spelling fixes and adapting of the tests.
The changes that matter are CCameraSceneNode.cpp, CCameraSceneNode.h and CSceneCollisionManager.cpp

Or check-out svn trunk itself and work with that.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
robmar
Posts: 1125
Joined: Sun Aug 14, 2011 11:30 pm

Re: [fixed]Cameras showing up in collisions

Post by robmar »

Thanks, I'm still using 1.7.3 so I'll just patch in those changes for now.
Post Reply