OpenGLDriver: Calling makeCurrent() on every beginScene() ?

[devsh]

Why are you doing this to me?

No, but really, what is the reason for calling changeRenderContext every frame?

*Its like the most painfully slow OpenGL call you can make (takes roughly 0.25ms)

[Nadro]

Hi,

Thanks for a report this issue, it'll be fixed in the upcoming commit.

Cheers,

[hendu]

I wonder if that's needed for the Qt and WxWidgets embedders?

[elvman]

Actually this is needed for OSX, because render context can be changed by OSX GUI. I fixed this bug for cocos2d-x by also making the context current before every frame: https://github.com/cocos2d/cocos2d-x/pull/14598

[Mel]

Perhaps you could make that "changeRenderContext" OSX specific then?

[hendu]

Qt and Wx also run on Linux, Windows, etc. So if they need it, you can't filter by platform.

[Nadro]

I'll check how this situation looks at OSX 10.9. If it will be required for Qt, wx etc. we can call glMakeCurrent only when SIrrlichtCreationParams::windowId isn't equal NULL, however IIRC this issue is just my mistake (missing simple 'if')