CTriangleSelector::getTriangles - not implemented ?

[bucheron]

It would be nice to write in the doc that getTriangles (for a aabbox32) is not properly implemented and that it doesn't return the triangles which are in a box, but all triangles !

Check below, you will see that the aabbox is not used at all. By the way, has anyone implemented the proper function ?

Code: Select all

//! Gets all triangles which lie within a specific bounding box.
void CTriangleSelector::getTriangles(core::triangle3df* triangles, 
									 s32 arraySize, s32& outTriangleCount, 
									const core::aabbox3d<f32>& box,
									const core::matrix4* transform)
{
	// return all triangles
	getTriangles(triangles, arraySize, outTriangleCount, transform);
}

[Electron]

Code: Select all

//! Gets all triangles which lie within a specific bounding box.
void CTriangleSelector::getTriangles(core::triangle3df* triangles, 
									 s32 arraySize, s32& outTriangleCount, 
									const core::aabbox3d<f32>& box,
									const core::matrix4* transform)
{    

    //changed by electron so actually only returns triangles in aabbox
   	s32 cnt = Triangles.size();
	if (cnt > arraySize)
		cnt = arraySize;

	core::matrix4 mat;

	if (transform)
		mat = (*transform);

	if (SceneNode)
		mat *= SceneNode->getAbsoluteTransformation();

    outTriangleCount=0;
	for (s32 i=0; i<cnt; ++i)
	{
        if(Triangles[i].isTotalInsideBox(box))
        {
		triangles[i] = Triangles[i];
		mat.transformVect(triangles[i].pointA);
		mat.transformVect(triangles[i].pointB);
		mat.transformVect(triangles[i].pointC);
		outTriangleCount++;
        }
	}
	
}

Note that this is already in IrrlichtNX