Controls don't work properly.

[scarface]

My code:

Code: Select all

 if (node != 0 && event.EventType == irr::EET_KEY_INPUT_EVENT&&
                !event.KeyInput.PressedDown)
        {
            switch(event.KeyInput.Key)
            {
                case KEY_KEY_S:
                {
                    core::vector3df v = cow->getPosition();
                    v.Y -=2.0f;
                    cow->setPosition(v);
                }
                case KEY_KEY_Z:
                {
                    core::vector3df v = cow->getPosition();
                    v.Y +=2.0f;
                    cow->setPosition(v);
                }
                case KEY_KEY_Q:
                {
                    core::vector3df v = cow->getPosition();
                    v.X -=2.0f;
                    cow->setPosition(v);
                }
                case KEY_KEY_D:
                {
                    core::vector3df v = cow->getPosition();
                    v.X +=2.0f;
                    cow->setPosition(v);
                }
                //return true;
            }
        }

Negative movements don't work (left/down), why?


Thanks.

[vitek]

Because you forgot to break out of the case blocks. If you press S, cases S, Z, Q and D would be executed and nothing would happen. If you just press Z then Z, Q and D would be executed and the object would be moved up.

Travis

[cadue]

excusme, you know how the switch work? you've forgot the "break" at the end of the "case". this is corret:

Code: Select all

 if (node != 0 && event.EventType == irr::EET_KEY_INPUT_EVENT&&
                !event.KeyInput.PressedDown)
        {
            switch(event.KeyInput.Key)
            {
                case KEY_KEY_S:
                {
                    core::vector3df v = cow->getPosition();
                    v.Y -=2.0f;
                    cow->setPosition(v);
                     break;  
                }
                case KEY_KEY_Z:
                {
                    core::vector3df v = cow->getPosition();
                    v.Y +=2.0f;
                    cow->setPosition(v);
                    break;  
                }
                case KEY_KEY_Q:
                {
                    core::vector3df v = cow->getPosition();
                    v.X -=2.0f;
                    cow->setPosition(v);
                    break;  
                }
                case KEY_KEY_D:
                {
                    core::vector3df v = cow->getPosition();
                    v.X +=2.0f;
                    cow->setPosition(v);
               break;                
               }
                //return true;
            }
        }

[cadue]

we've posted the message in the same moment!

[Baal Cadar]

The code is also very repetitive. Better style:

Code: Select all

    core::vector3df delta();

    if (event.KeyInput.Key == KEY_KEY_S)
        delta.Y = -2.0f;
    else if (event.KeyInput.Key == KEY_KEY_Z)
        delta.Y =  2.0f;
    else if (event.KeyInput.Key == KEY_KEY_Q)
        delta.X = -2.0f;
    else if (event.KeyInput.Key == KEY_KEY_D)
        delta.X =  2.0f;

    cow->setPosition(cow->getPosition() + delta);

[scarface]

I understand, thanks

[vitek]

The code is also very repetitive. Better style:...

Well, except yours wouldn't compile [core::vector3df delta() would seen as a function declaration].

[Baal Cadar]

Yes. make it core::vector3df delta; then.