[fixed in 1.8.1] Clone method crash my application

[christianclavet]

Hi, just wanted to know if this is a bug or there is another way to use the clone method.

Everytime I start the application I get a crash and the debugger point me to this in CMeshSceneNode.cpp:

line 432...

Code: Select all

    nb->cloneMembers(this, newManager);
    nb->ReadOnlyMaterials = ReadOnlyMaterials;
    nb->Materials = Materials;
    nb->Shadow = Shadow;
    nb->Shadow->grab();  <--- Debugger stop to this line.

I commented out the 2 last lines and it did not crash ( I'm not using the shadow volume ).

I have also another problem, some of animated model I have (not all) are moving in reverse (perhaps the changes in matrix), and I also have the shaders that seem broken and I don't know why (using Debug DLL and don't see any message in the console), posted another message in the help section for the shader has it could be a method change that I'm unaware of.

[Nadro]

This is a bug. The code should looks like this:

Code: Select all

if(nb->Shadow)
nb->Shadow->grab();

[christianclavet]

Ok, I'll add correction this for now. I was using this method to clone the objects in the editor. Thanks!

[ACE247]

Thanks for this too, had the same issue in my Scene Editor Code.

[hybrid]

Sorry, my fault. I didn't test the clone method

[CuteAlien]

Fixed now in svn it will be in 1.8.1.

[marsupial]

Hey,

it seems like the bug descriped here also applies to CCubeSceneNode::clone(), CSphereSceneNode::clone() and CAnimatedMeshSceneNode::clone().
At least in CCubeSceneNode.cpp it didn't seem to be fixed in the latest SVN revision.

So, as far as I understand, querying the shadow variable first with

Code: Select all

if(nb->Shadow)
nb->Shadow->grab();

should fix the issues.
Would be cool to see this getting fixed in 1.8.1 as well

Thanks!

[CuteAlien]

Ow - I should have checked if there is more than one such place when fixing it. Thanks for seeing that marsupial! Fixed now in the 1.8 svn branch, so it will be in 1.8.1

[Squarefox]

Any Chance that 1.8.1 will be released soon? The clone crash is very nasty. I'm currently writing a library for Irrlicht, that's why I cannot use the trunk if other people shall be able to use the library also.

[CuteAlien]

Hm... good question. Bascially I wanted at least this bug fixed first before doing another release: http://irrlicht.sourceforge.net/forum/v ... 85#p277885 but it's pretty tricky as it could count as breaking the interface. So I had hoped for some more feedback there, but got none :-(

And then I have to find time for testing a release *sigh*.

I agree we should have a 1.8.1 out since months, but can't make any promise right now, sorry. Maybe I just make a release without fixing the trouble mentioned above and plan that for an 1.8.2, but not too keen on it as finding the 1-2 free days needed for testing is also always hard.

[CuteAlien]

Hm, thought about that all evening. We really need to get 1.8.1 out. I have a few things I'm going to do first (stuff I already started), but afterward I'll care about getting that version out. Unless too much stuff comes in between (often happens unfortunately) it might be possible to manage a release around end of october.

[Squarefox]

Sounds very nice - looking forward to the release.

[Squarefox]

Hi CuteAlien,

what's about 1.8.1? Will it be released soon?

Regards,
Squarefox

[CuteAlien]

Sorry, version is basically ready, I just didn't have motivation to finish testing it last weekends (takes a while doing that on all systems and is pretty boring, not quite a fun way to spend the weekend ...). I try again to finish tomorrow, then I'll make a zip for others in the team to test... so I hope next week it's finally done.

[AReichl]

I could help testing ( WIndows: gcc, Visual Studio 2008, 2010, 2012 ).
No Linux at the moment.